-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add ConversationTokenBufferMemory #2753
Comments
🤖 That's great to hear! Adding a This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot. |
Hi! I would like to work on this issue. I will take this on later this week. Thanks in advance! |
Great! If I had more time, I would've started already but this remains to be seen for the week. Will be on the lookout for your PR. |
@danny-avila after taking a look into the ticket, I noticed that method This is my first PR in an open-source repository so thank you in advance for your patience, and any advice is greatly appreciated! |
Hi, @danny-avila, I'm helping the langchainjs team manage their backlog and am marking this issue as stale. From what I understand, you proposed adding ConversationTokenBufferMemory to the repository, inspired by a similar feature in the Python counterpart. You and @ychen5601 have been discussing the potential pull request, and it seems there was a modest delay due to an unimplemented method from the Python repo in the JavaScript repo. Could you please confirm if this issue is still relevant to the latest version of the langchainjs repository? If it is, please let the langchainjs team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days. Thank you! |
Been running into needing this, from Python counterpart: https://python.langchain.com/docs/modules/memory/types/token_buffer
Maybe I can put in a PR for this as it's simple enough looking at the other memory classes.
The text was updated successfully, but these errors were encountered: