Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cohere-embed v3.0 #3138

Closed
ojpetar opened this issue Nov 2, 2023 · 6 comments · Fixed by #3263
Closed

Add support for cohere-embed v3.0 #3138

ojpetar opened this issue Nov 2, 2023 · 6 comments · Fixed by #3263
Assignees
Labels
auto:improvement Medium size change to existing code to handle new use-cases

Comments

@ojpetar
Copy link

ojpetar commented Nov 2, 2023

The new cohere embed models have an additional mandatory parameter that needs to get passed when creating embeddings - would be awesome to get langchain support for this!

New embed endpoint docs + docs on additional parameters: https://txt.cohere.com/introducing-embed-v3/

Copy link

dosubot bot commented Nov 2, 2023

🤖

Hello @ojpetar,

I'm Dosu, a friendly bot here to assist you while we wait for a human maintainer. I can help you solve bugs, answer questions, and guide you on becoming a contributor. I'm here to make your experience with the langchainjs repository as smooth as possible. Let's work together!

Best,
Dosu

It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Nov 2, 2023
@bracesproul
Copy link
Collaborator

Hey @ojpetar it looks like cohere's typescript SDK does not currently support it, however there is a PR up in their repo with an implementation. Once that PR is merged we'll add support here!

@bracesproul bracesproul added the hold On hold label Nov 3, 2023
@squamos
Copy link

squamos commented Nov 13, 2023

@bracesproul can you link to the open issue in cohere's typesccript sdk to follow? having the same issue

@bracesproul
Copy link
Collaborator

@bracesproul can you link to the open issue in cohere's typesccript sdk to follow? having the same issue

There isn't an open issue however this is the PR which added support in their repo

@bracesproul bracesproul removed the hold On hold label Nov 14, 2023
@bracesproul bracesproul self-assigned this Nov 14, 2023
@squamos
Copy link

squamos commented Nov 14, 2023

Thanks @bracesproul - how often do you publish npm version updates? Looking forward to trying this out!

@bracesproul
Copy link
Collaborator

Thanks @bracesproul - how often do you publish npm version updates? Looking forward to trying this out!

We'll publish one tonight! Normally we do it at the end of business hours PST (ish).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants