Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change wording for CAT-CDI #375

Closed
vmarchman opened this issue Mar 10, 2022 · 9 comments
Closed

change wording for CAT-CDI #375

vmarchman opened this issue Mar 10, 2022 · 9 comments
Assignees

Comments

@vmarchman
Copy link
Contributor

vmarchman commented Mar 10, 2022

@HenryMehta We want to change the wording in the question for parents to:

"Does your child say...."

rather than

"Can you child say...."

@kachergis What is the wording for Spanish?

HenryMehta added a commit that referenced this issue Mar 30, 2022
@HenryMehta
Copy link
Collaborator

@vmarchman
I'm deploying to development now.
We don't currently provide anything except an English version of CAT. The code isn't there to do multiple languages

@HenryMehta HenryMehta self-assigned this Mar 30, 2022
@kachergis
Copy link
Member

@vmarchman it's more a question for @HenryMehta -- I can give him the final parameters for the Spanish CAT, so I imagine it's fairly straightforward to adapt the English CAT template for use with the Spanish items, but may take a couple hours and require a bit of testing?

@HenryMehta
Copy link
Collaborator

I think it might be a little longer than 2 hours. The current API for the cat is written for English only. It would need amending to take multiple languages which then also means the API calls from WebCDI will need amending. We currently only have a production version of the CAT API so we would need to

  1. create a development version,
  2. have the development WebCDI point at the development CAT API.
  3. amend the API to handle multiple languages and import the Spanish data
  4. amend WebCDI to call Cat API according to the new API structure
  5. Test both English and Spanish to ensure working
  6. Deploy

Probably more like a couple, possibly three, of days I think

@vmarchman
Copy link
Contributor Author

@HenryMehta Let's hold off on the Spanish for now. We will make CAT more flexible wrt other languages (e.g., French) and then build Spanish in that process

@HenryMehta HenryMehta reopened this Apr 1, 2022
@HenryMehta
Copy link
Collaborator

@vmarchman I am reopening this until the text change is in production

@vmarchman
Copy link
Contributor Author

vmarchman commented Apr 1, 2022 via email

@HenryMehta
Copy link
Collaborator

yes, just waiting on lookit to be signed off

HenryMehta added a commit that referenced this issue Jun 7, 2022
* #374 Introduce hide source id and combine child/response into source_id

* Correction to CATCDI filename

* #375 Change CAT question text

* CATCDI Fix at 50 responses

* Bump cairosvg from 2.4.2 to 2.5.1 (#381)

Bumps [cairosvg](https://github.com/Kozea/CairoSVG) from 2.4.2 to 2.5.1.
- [Release notes](https://github.com/Kozea/CairoSVG/releases)
- [Changelog](https://github.com/Kozea/CairoSVG/blob/master/NEWS.rst)
- [Commits](Kozea/CairoSVG@2.4.2...2.5.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump django from 2.2.13 to 2.2.25 (#382)

Bumps [django](https://github.com/django/django) from 2.2.13 to 2.2.25.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@2.2.13...2.2.25)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pillow from 7.1.2 to 8.3.2 (#383)

Bumps [pillow](https://github.com/python-pillow/Pillow) from 7.1.2 to 8.3.2.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst)
- [Commits](python-pillow/Pillow@7.1.2...8.3.2)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump lxml from 4.6.4 to 4.6.5 in /webcdi (#384)

Bumps [lxml](https://github.com/lxml/lxml) from 4.6.4 to 4.6.5.
- [Release notes](https://github.com/lxml/lxml/releases)
- [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
- [Commits](lxml/lxml@lxml-4.6.4...lxml-4.6.5)

---
updated-dependencies:
- dependency-name: lxml
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pypdf2 from 1.26.0 to 1.27.5 in /webcdi (#386)

Bumps [pypdf2](https://github.com/py-pdf/PyPDF2) from 1.26.0 to 1.27.5.
- [Release notes](https://github.com/py-pdf/PyPDF2/releases)
- [Changelog](https://github.com/py-pdf/PyPDF2/blob/main/CHANGELOG)
- [Commits](py-pdf/pypdf@1.26.0...1.27.5)

---
updated-dependencies:
- dependency-name: pypdf2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* #adding Argentine WG form

* Django to 3.2

* Add Argentian WG to word categories.csv

* Add Argentian WG to word categories.csv

* Add Argentian WG to word categories.csv

* Translations from Argentinian WG

* Translations from Argentinian WG

* Adding some translations to Argentinian Spanish WG Meta

* Mariela changes

* Mariela changes

* translation change

* Argentinian WG change

* Argentinian Changes

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vmarchman
Copy link
Contributor Author

vmarchman commented Oct 11, 2022 via email

@kachergis
Copy link
Member

Hi @vmarchman, I've already modified the API to load the Spanish parameters and handle requests for the Spanish (production) CAT (Henry's step 3 above, and he has done the other steps for English and now French). The remaining pieces are 1) translation of the carrier phrase and any other special instructions to be given for the CAT, and 2) adding/checking disambiguation. I know I asked for Paulina's help with that quite some time ago, but looking through old emails I'm not sure it was ever completed -- I can ping her to double-check (I may have misplaced it..). Are people eager for it? ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants