Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen page progress bar can show text past the bounds of the audio #1

Open
SyntaxBlitz opened this issue May 28, 2020 · 0 comments
Open
Labels
bug Something isn't working

Comments

@SyntaxBlitz
Copy link
Contributor

I noticed while testing the app that the progress bar briefly showed "5:15 / 5:14" on the Listen page.

This could be caused by a few things, but it's probably inconsistent rounding or metadata that's inconsistent with the file (or with the player's perception of the file length).

Ideally, we'd never render an "impossible" time, but we should also account for the possibility that the metadata may truly be wrong. For example, if the downloaded metadata says the track length is 2:00 and the track is truly 10:00, we don't want to show "2:00 / 2:00" for 8 minutes.

Options:

  • Show the time with a ceiling (5:14 / 5:14) for a second or two, then snap back to showing an impossible time (5:17 / 5:14) if the track keeps playing past what the metadata says the length of the track is.
  • When the progress exceeds the length of the track, change the track length display maybe to the current progress, or maybe just a "?:??" as we admit we have no idea how long the track is.
@SyntaxBlitz SyntaxBlitz added the bug Something isn't working label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant