Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upperleft coordinates in output #5

Merged
merged 1 commit into from
Feb 12, 2019
Merged

fix upperleft coordinates in output #5

merged 1 commit into from
Feb 12, 2019

Conversation

IgnacioHeredia
Copy link

Hi Charis,

First of all thanks for sharing the code, the work looks great!
I found a bug in the test script s2_tiles_supres.py and wanted to contribute with a fix.

The problem is that when you superresolve only a part of the image (let's say roi_x_y='500,500,2500,2500') the output image has the origin upperleft coordinates equal to the ones in original image, while it should have ori_coord + (500,500).

Let me show you with some images, as it's going to be clearer.

Original code

python s2_tiles_supres.py path_to_xml output_file.tif --roi_x_y "0,0,2500,2500"
image

python s2_tiles_supres.py path_to_xml output_file.tif --roi_x_y "500,500,2500,2500"
image

After the changes in this pull request
python s2_tiles_supres.py path_to_xml output_file.tif --roi_x_y "500,500,2500,2500"
image

I just started using gdal but I hope this fixes the issue.

Thanks again,

Ignacio

@lanha lanha merged commit 3f07741 into lanha:master Feb 12, 2019
@lanha
Copy link
Owner

lanha commented Feb 12, 2019

Cool! thanks :)

CarlosFora pushed a commit to CarlosFora/DSen2 that referenced this pull request Sep 22, 2021
* Freeze keras version to be compatible with tf1

* minor refactoring

* Revert naming of saved patches.

* Uncomment the commented line

* Add tests for inference

* Black update and fix some liniting issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants