Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Solved] problems compiling FEHM with intel visual fortran #22

Closed
jbensabat opened this issue Aug 28, 2019 · 3 comments
Closed

[Solved] problems compiling FEHM with intel visual fortran #22

jbensabat opened this issue Aug 28, 2019 · 3 comments

Comments

@jbensabat
Copy link

Hello
I am trying to build FEHM with intel Visual fortran under windows.
I get a large number of errors of the same type around this portion of code

c add coding to save upwind position
if(iad.le.iad_up) then
fid=0.5
axyd=t8(neighc)
if(axyd.lt.0.0) fid=dnwgt
if(axyd.gt.0.0) fid=upwgt
t9(neighc)=fid
c
call setbit(nbits,neighc,upwind_l(iz4m1),fid)
c
else
if(bit(nbits,neighc,upwind_l(iz4m1))) then
t9(neighc)=1.0
else
t9(neighc)=0.0
endif
endif
the error arises because subroutine setbit accepts integers only but the array upwind_l if real.
I saw that in some routines any reference to setbit was commented
Is it ok to do so ?
thanks
jac

@daniellivingston
Copy link
Member

Hi Jac, try commenting out bit and setbit:

I would say that if the new Intel compiler does not work with 'bit' and 'setbit' we comment out those. Macro 'itup' will be essentially disabled but very few of us have used it. I think no test cases do.

@jbensabat
Copy link
Author

Hi and thank you for your support
I resolved this issue by checking out the flag "Check Routine Interfaces" in the "Diagnostics" option of the fortran workspace properties. I was able then to build FEHM. There are two types of issues: 1) related to the setbit subroutine - the dummy arguments are all integer (4 bytes) while the third argument in the calling is of type real*8. even if compilation goes thru I am not sure that results could be reliable; 2) there are many cases where the size of dummy arrays are larger than the ones in the calling sequence - but this is not a problem.

thanks
jac

@daniellivingston
Copy link
Member

Great! Thanks for posting your solution. We'll include it in build documentation. I'm marking this as closed, then. Please re-open if any additional issues related to this topic appear.

@daniellivingston daniellivingston changed the title problems compiling FEHM with intel visual fortran [Solved] problems compiling FEHM with intel visual fortran Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants