Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating lanl/voronoi code with LaGriT #209

Open
daniellivingston opened this issue Aug 20, 2020 · 4 comments
Open

Integrating lanl/voronoi code with LaGriT #209

daniellivingston opened this issue Aug 20, 2020 · 4 comments
Assignees

Comments

@daniellivingston
Copy link
Member

Interface the Voronoi codebase with LaGriT to supersede the dump/stor and dump/pflotran commands. The Voronoi + LaGriT codebase already exists, but is about 1.5 years out of date and not completely production ready. We’d need to: update the LaGriT Makefile, add test suite cases, merge/clean up the two codebases, and add those compiler directives.

@daniellivingston
Copy link
Member Author

The Voronoi code fundamentally relies on PETSc data structures to compute. Because PETSc is such a heavy dependency, it's proposed that we use compiler directives to allow compiling with Voronoi/PETSc to be optional. For example:

subroutine voronoi(args)
#ifndef HAS_PETSC
       write(*,*) "petsc required to use this subroutine; returning"
#else
c      [do voronoi stuff]
#endif
end subroutine voronoi

@millerta
Copy link
Collaborator

millerta commented Jan 7, 2022

While fixing cmake to build with Exodus, look into similar scripts for Petsc option.
Stable but old code for Voronoi is at https://github.com/lanl/voronoi
Is there something newer?
See lanl/voronoi#15

@millerta millerta pinned this issue Jan 7, 2022
@millerta
Copy link
Collaborator

Find most recent version of Voronoi working with Petsc. From Daniel's note above:
The Voronoi + LaGriT codebase already exists, but is about 1.5 years out of date and not completely production ready.

@millerta
Copy link
Collaborator

From Daniel note:

PETSc integration:
find_package(PETSc v3.3.3 REQUIRED)
PETSc_FOUND
PETSc_INCLUDE_DIRS
PETSc_LIBRARIES


if (PETSc_FOUND)
    # add voronoi source
    set(TPL_LIBRARIES "${PETSc_LIBRARIES}")
    set(TPL_INCLUDE_DIRS "${PETSC_INCLUDE_DIRS} ..."")
endif()

@millerta millerta unpinned this issue Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants