Tab vs. Space Policy

[tbalke]

Do we have a policy for this?

We seem to be inconsistent. A search through the repo shows:

<space><space><space><space> found in 141 files
\tab found in 22 files

(Some false positives because of binary files)

@bwohlberg @Michael-T-McCann

[Michael-T-McCann]

Black solves this for us (that is, stops us from arguing over it). Spaces is what Black does, so spaces is what we do.

[bwohlberg]

According to PEP 8

Spaces are the preferred indentation method.

Tabs should be used solely to remain consistent with code that is already indented with tabs.

I don't think it's a big issue, but we could add a pre-commit hook to replace tabs with spaces.

[bwohlberg]

Black solves this for us (that is, stops us from arguing over it). Spaces is what Black does, so spaces is what we do.

I guess the tabs that @tbalke found must have sneaked in before we introduced the Black pre-commit hook.

[bwohlberg]

Correction: all the tabs are in the docs .rst files, which is obviously why Black didn't do the replacement.

[tbalke]

Correction: all the tabs are in the docs .rst files, which is obviously why Black didn't do the replacement.

Really? See my comment in the PR.