Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue #291 #355

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Resolve issue #291 #355

merged 5 commits into from
Oct 24, 2022

Conversation

bwohlberg
Copy link
Collaborator

Resolve issue #291.

@bwohlberg bwohlberg added the improvement Improvement of existing code, including addressing of omissions or inconsistencies label Oct 20, 2022
@bwohlberg bwohlberg linked an issue Oct 20, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #355 (bb082b3) into main (605ba76) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   94.10%   94.12%   +0.01%     
==========================================
  Files          56       57       +1     
  Lines        3361     3354       -7     
==========================================
- Hits         3163     3157       -6     
+ Misses        198      197       -1     
Flag Coverage Δ
unittests 94.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/optimize/_admm.py 97.29% <100.00%> (-0.12%) ⬇️
scico/optimize/_common.py 100.00% <100.00%> (ø)
scico/optimize/_ladmm.py 98.79% <100.00%> (-0.07%) ⬇️
scico/optimize/_pgm.py 94.31% <100.00%> (+0.76%) ⬆️
scico/optimize/_primaldual.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big readability improvement! I appreciate the new lack of exec and links to stackoverflow in the ADMM __init__.py.

@bwohlberg bwohlberg merged commit edc00ed into main Oct 24, 2022
@bwohlberg bwohlberg deleted the brendt/issue#291 branch October 24, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve iterations stats initialization in solver classes
2 participants