Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve iterations stats initialization in solver classes #291

Closed
bwohlberg opened this issue May 6, 2022 · 0 comments · Fixed by #355
Closed

Improve iterations stats initialization in solver classes #291

bwohlberg opened this issue May 6, 2022 · 0 comments · Fixed by #355
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies

Comments

@bwohlberg
Copy link
Collaborator

bwohlberg commented May 6, 2022 •
edited
Loading

The iteration stats initialization in the solver classes is rather messy, and could perhaps be improved by moving it into a private support class for each solver class.

Quote from @Michael-T-McCann in #290:

This itstat initialization is always a stumbling block for me when reading the class. Could it be easily refactored into its own function/class?
@bwohlberg bwohlberg added the improvement Improvement of existing code, including addressing of omissions or inconsistencies label May 6, 2022
@bwohlberg bwohlberg mentioned this issue Oct 20, 2022
Merged
@bwohlberg bwohlberg linked a pull request Oct 20, 2022 that will close this issue
Resolve issue #291 #355
Merged
bwohlberg added a commit that referenced this issue Oct 24, 2022
@bwohlberg
Resolve issue #291 (#355)
edc00ed 
* Move iteration stats initialization into separate method

* Add typing

* Clean up

* Address mypy error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve issue #291 lanl/scico
1 participant
@bwohlberg