New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignored Particles in Pusher Should have their update to cell index undo to avoid accessing out of bounds memory #118

Closed

rfbird opened this issue Aug 11, 2020 · 1 comment

Contributor

rfbird commented Aug 11, 2020

https://github.com/lanl/vpic/blob/devel/src/species_advance/standard/pipeline/advance_p_pipeline.cc#L310

Currently only throws a warning about a situation where we are likely allowing the code to go out of bounds in memory. We should either

A) Have this section https://github.com/lanl/vpic/blob/devel/src/species_advance/standard/pipeline/advance_p_pipeline.cc#L230 undo the bit shift done by move_p

or B) throw an error and die

Contributor Author

rfbird commented Sep 15, 2020

fixed by #121

rfbird closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment