Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw pr curve with provided raw data. #98

Closed
foreverYoungGitHub opened this issue Mar 10, 2018 · 10 comments
Closed

Draw pr curve with provided raw data. #98

foreverYoungGitHub opened this issue Mar 10, 2018 · 10 comments

Comments

@foreverYoungGitHub
Copy link

Hi,

Thanks so much for you to provide so convenient tools to visualize the process for pytorch.

Recently, I want draw the pr curve and other curves with tensorboard by directly provided the precision and recall values. However, I found that the inputs of add_pr_curve is the predict value and ground truth. It calculated the pr curve by using compute_curve().

Is that possible that add a new interface like add_pr_curve_raw to add pr curve officially by provided the raw data. Just like pr_curve_raw_data_pb in tensorboard.

Thanks so much!

Best wishes,

@lanpa
Copy link
Owner

lanpa commented Mar 11, 2018

No problem.

@foreverYoungGitHub
Copy link
Author

Thanks so much!

@lanpa lanpa closed this as completed in 71adb14 Mar 13, 2018
@lanpa
Copy link
Owner

lanpa commented Mar 13, 2018

@foreverYoungGitHub Have a try~

@foreverYoungGitHub
Copy link
Author

Thank you for your help!

I draw some pr_curves and other curves like this:

pr_curve

Thanks for your help!

Besides, do you have any plan to add something like custom_scalar?

Thanks again for your work!

Best wishes,

@lanpa
Copy link
Owner

lanpa commented Mar 20, 2018

So does the result make sense? custom_scalar is cool, I will bring it to tensorboardX.

@foreverYoungGitHub
Copy link
Author

It is great to hear that!

The current result is great! Just some curve does not belong to PR curve and it has to normalize into 0 to 1. But it's some minor problem.

@MaximArtemev
Copy link

Hi!
Any success with bringing custom_scalar into tensorboardX?

@lanpa
Copy link
Owner

lanpa commented Jul 7, 2018

@MaximArtemev Haven't start yet. 😂

@zhanghanbin3159
Copy link

zhanghanbin3159 commented Aug 1, 2018

@foreverYoungGitHub how do you draw pr-curve with the precision and recall values? the add_pr_curve_raw function ?

@foreverYoungGitHub
Copy link
Author

@zhanghanbin3159 please check this code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants