Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is the audio sample rate fixed at 44100? #34

Closed
greaber opened this issue Sep 26, 2017 · 2 comments
Closed

Why is the audio sample rate fixed at 44100? #34

greaber opened this issue Sep 26, 2017 · 2 comments

Comments

@greaber
Copy link
Contributor

greaber commented Sep 26, 2017

From glancing at the code, the audio function in summary.py seems to take a sample rate argument, so it looks like it would be trivial for the add_audio method of SummaryWriter to take an optional sample rate argument and pass it along to audio. Is there some complicating factor here?
@lanpa
Copy link
Owner

lanpa commented Sep 26, 2017

Because I think nobody cares about it. lol

Would you like to send a PR?

@greaber
Copy link
Contributor Author

greaber commented Sep 26, 2017

Sure. I'm planning to switch from crayon to tensorboard-pytorch to be able to log audio, and I will make a pull request to add this feature as part of that.

@greaber greaber closed this as completed Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lanpa @greaber