Setting Language to English Breaks Website

[TheDeadCPU]

Hi, so after succesfully installing, I opened up the website, and changed the language from German to English, this made the website stop functioning, and throwing a lot of PHP errors.

Here's a imgur gallery with the php errors.
https://imgur.com/a/mUMN4RD

Expected Behavior

Changing language to English should change language to English

Current Behavior

Selecting English breaks the website.

Steps to Reproduce (for bugs)

1. Start fresh server
2. On setup page change to english and hit apply.

Your Environment

• Version used: Latest
• Operating System and version: Ubuntu Server 18.04
• Docker Version: 18.06.1-CE
• Docker Compose Version: 1.22.0

[M4LuZ]

Looks like your translations are not loaded and it fails to translate the error message that it cannot translate the error message. Ending in a recursive loop of no return.

On setup page change to english and hit apply.

I guess that means you are running a fresh docker installation?

[TheDeadCPU]

I am indeed using a completely fresh docker installation.
The server has been setup virtually, docker-ce installed, and docker-compose.
Then used the steps over at https://lansuite.github.io/lansuite/docs/installation.html

Added "fresh" to the first step to reproduce the issue, to make it more clear that it was a fresh installation.

[M4LuZ]

As far as I can tell from a first look:
German translations are always loaded
Translation function uses these directly and the DB in any other case
But translations from the DB are not loaded during the setup stage, as the DB connection is not yet configured.

Proposed solution:
Modify translation function to follow three stages:

• Check if given translaton is loaded
• Try to load it from the DB
• Try to load it from the text file if it fails. Try to update DB.
• Return untranslated text with warning if that also fails.

That should work for all cases, shouldn't it?

What I'm wondering: Why has this never popped up?
It does not look like this ever worked.
Or maybe it has, but we're not aware due to #239

[TheDeadCPU]

As a workaround, I set the site up using german language, using google translate works well for those that can't work their way around the german.
Afterwards setting the language to english does work. (even though there's quite a lot of stuff not translated, but this can be done manually)