Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizable fonts for title, headings, body #125

Open
mbrukman opened this issue May 25, 2019 · 0 comments
Open

Support customizable fonts for title, headings, body #125

mbrukman opened this issue May 25, 2019 · 0 comments
Assignees

Comments

@mbrukman
Copy link
Contributor

It looks like the the current title font family is hard-coded to Lobster, and it's not easy to change as it's hard-coded in many places, with no way to substitute a new family via params:

  • assets/styles/partials/_header.scss shows:

    .title {
      /* [...] */
      font-family: $family-lobster;
  • layouts/partials/head.html includes two explicit references, on line 127:

    <link rel="preload" href="https://fonts.googleapis.com/css?family=Lobster" as="style">

    and on line 142:

    <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Lobster">
  • assets/service-worker-template.js explicitly requests Lobster font:

    // Google fonts
    'https://fonts.googleapis.com/css?family=Lobster',
    'https://fonts.gstatic.com/s/lobster/v20/neILzCirqoswsqX9zoKmM4MwWJU.woff2',
  • assets/styles/partials/_variables.scss explicitly calls the style with the name "lobster":

    $family-lobster: 'Lobster', cursive, $family-sans-serif;

This makes it hard to swap out the font style for the heading for a different font family, without there being parameters to change it easily.

Would it be possible to make it parameterized to enable easier font substitution? Thanks!

@laozhu laozhu self-assigned this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants