Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect effectiveness flash during heal #40

Open
laqieer opened this issue Jul 8, 2022 · 0 comments
Open

Incorrect effectiveness flash during heal #40

laqieer opened this issue Jul 8, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@laqieer
Copy link
Owner

laqieer commented Jul 8, 2022

Problem

Healed target's equipped weapon is treated as effectiveness incorrectly.
fe7-jp-stunning-tribble-0

Reason

gBattleTarget.weaponBefore is set during heal while gBattleTarget.weapon is not, and IsItemEffectiveAgainst accepts bu->weapon as argument, so if the previous battle target's weapon happens to be effective against the current healer, bug happens.
@laqieer laqieer added the bug Something isn't working label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laqieer