-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code review #1
Comments
@freekmurze Ready :) |
Ok, hold off from making commits for the coming half hour. |
Ok, I made some changes, nothing big, all details. However the tests seems to fail. You'll need to use something like |
Thanks! Made one comment, 3eae0e7#commitcomment-18624165, but agree with everything else. Will look into the tests, was only running them in a Laravel app until now ;). |
Fixed the tests. |
Great! Big thumbs up for those integration tests! |
Thanks :) |
@casperboone Ping me when ready, then I'll do a code review
The text was updated successfully, but these errors were encountered: