Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #1

Closed
freekmurze opened this issue Aug 12, 2016 · 7 comments
Closed

Code review #1

freekmurze opened this issue Aug 12, 2016 · 7 comments

Comments

@freekmurze
Copy link
Member

@casperboone Ping me when ready, then I'll do a code review

@casperboone
Copy link
Member

@freekmurze Ready :)

@freekmurze
Copy link
Member Author

Ok, hold off from making commits for the coming half hour.

@freekmurze
Copy link
Member Author

Ok, I made some changes, nothing big, all details.

However the tests seems to fail. You'll need to use something like orchestra/testbench to make 'm pass on Travis.

@casperboone
Copy link
Member

Thanks! Made one comment, 3eae0e7#commitcomment-18624165, but agree with everything else.

Will look into the tests, was only running them in a Laravel app until now ;).

@casperboone
Copy link
Member

Fixed the tests.

@freekmurze
Copy link
Member Author

Great! Big thumbs up for those integration tests!

@casperboone
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants