Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require dompdf/dompdf #1311

Closed
PHLAK opened this issue Jan 31, 2022 · 3 comments
Closed

Don't require dompdf/dompdf #1311

PHLAK opened this issue Jan 31, 2022 · 3 comments

Comments

@PHLAK
Copy link

PHLAK commented Jan 31, 2022

We use spatie/browsershot for our app's interal PDF rendering and with the introduction of #1304 we plan to switch Cashier over to use browsershot as well (instead of dompdf/dompdf). However, since dompdf/dompdf is still a required package it will still be installed in all environments, even when unused. It would be nice if dompdf/dompdf were no longer a required package to eliminate an unnecessary dependency. However I know simply moving it to suggest isn't straight forward and thus opened this issue to discuss if you think this would be possible and how to go about making that change. If this is possible/desirable I am willing to work on a PR.

@driesvints
Copy link
Member

I agree. Attempted a PR here for the next major release since it's a breaking change: #1312

@arborrow
Copy link

arborrow commented Jul 7, 2022

I commented on #1084 but figured this might be a good place to mention as well. Is there a sense of when 14 might be pushed out? Given CVE-2022-0085 it might be helpful to get the unused dompdf/dompdf package off people's systems.

@driesvints
Copy link
Member

Please see #1393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants