[10.x] Refactor handling of invalid webhook signatures #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can rid of the `\Illuminate\Contracts\Foundation\Application` dependency in the `VerifyWebhookSignature` constructor, by manually throwing a 403 exception. This simplifies both the implementation and the tests, and it allows us to pass the message and the original exception to the exception handler.
sebdesign
force-pushed
the
feature/invalid-webhook-signatures
branch
from
799aea0
to
6ce9d8a
Compare
driesvints
changed the title
driesvints
approved these changes
Sep 27, 2019
|
On thing on my mind is people extending the class and using the app property but that seems very unlikely tbh. |
|
Yeah I doubt people would want to extend this middleware. :) |
|
@driesvints should we remove the config repository dependency as well? We are using |
|
@sebdesign I think that was still needed for the tests but if you can simplify it then go for it. |
|
@driesvints I'll do it tonight! The goal is to simplify tests as well. |
sebdesign
added a commit
to sebdesign/cashier
that referenced
this pull request
Sep 30, 2019
Similarly to laravel#791, we can remove the `\Illuminate\Contracts\Config\Repository` in the `VerifyWebhookSignature`'s constructor. For consistency, the configuration is accessed with the `config()` helper like the rest of the code. Since we don't need to mock the configuration repository anymore, the test has been moved to the integration suite, because we need to bootstrap the framework. As a bonus, I have added tests for checking [replay attacks](https://stripe.com/docs/webhooks/signatures#replay-attacks) against the tolerance configuration setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can rid of the
\Illuminate\Contracts\Foundation\Applicationdependency in theVerifyWebhookSignatureconstructor, by manually throwing a 403 exception.This simplifies both the implementation and the tests, and it allows us to pass the message and the original exception to the exception handler.