Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Refactor handling of invalid webhook signatures #791

Merged
merged 1 commit into from
Sep 27, 2019
Merged

[10.x] Refactor handling of invalid webhook signatures #791

merged 1 commit into from
Sep 27, 2019

Commits on Sep 26, 2019

  1. Refactor handling of invalid webhook signatures 

    We can rid of the `\Illuminate\Contracts\Foundation\Application` dependency in the `VerifyWebhookSignature` constructor, by manually throwing a 403 exception.

This simplifies both the implementation and the tests, and it allows us to pass the message and the original exception to the exception handler.
    @sebdesign
    sebdesign committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    6ce9d8a View commit details
    Browse the repository at this point in the history