[10.x] Remove config repository dependency from webhook middleware #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to laravel#791, we can remove the `\Illuminate\Contracts\Config\Repository` in the `VerifyWebhookSignature`'s constructor. For consistency, the configuration is accessed with the `config()` helper like the rest of the code. Since we don't need to mock the configuration repository anymore, the test has been moved to the integration suite, because we need to bootstrap the framework. As a bonus, I have added tests for checking [replay attacks](https://stripe.com/docs/webhooks/signatures#replay-attacks) against the tolerance configuration setting.
|
@sebdesign I think I now realize why this was a unit test. Because we're now using the container to resolve config dependencies we can't unit test the middleware anymore. The reply attack tests are nice though. Can you maybe send in a new PR with the old implementation? Thanks! |
|
But do we really need to unit test the middleware? Isn't an integration test as much as valuable? I'll send an other PR with the timing tests though, but I don't believe it's worth injecting the config repository just to be able to isolate this middleware, while the config is resolved with the helper in all the other places. What do you think? |
|
Okay, I agree after consideration. |
driesvints
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #791, we can remove the
\Illuminate\Contracts\Config\Repositoryin theVerifyWebhookSignature's constructor. For consistency, the configuration is accessed with theconfig()helper like the rest of the code.Since we don't need to mock the configuration repository anymore, the test has been moved to the integration suite, because we need to bootstrap the framework.
As a bonus, I have added tests for checking replay attacks against the tolerance configuration setting.