Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo.ts checks for globals instead of properties installed on the window object #70

Closed
kylestev opened this issue Dec 8, 2016 · 0 comments

Comments

@kylestev
Copy link
Contributor

kylestev commented Dec 8, 2016

Background

Laravel 5.3's default javascript scaffolding requires resources/assets/js/bootstrap.js at the top of the resources/assets/js/app.js file. The bootstrap.js file has side effects when required that mutates the window object due to the way that the vue and vue-resource packages install themselves globally.

Side effects

Package Side Effect
vue Installs property Vue onto window
vue-resource Installs property http onto window.Vue

Issue

The issue here is that this library is checking for a global instead of a property on the window. This becomes apparent when using this library without bootstrap.js scaffolding shipped with Laravel 5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants