Merge pull request #28502 from staudenmeir/validation

[5.8] Fix validation with multiple passes() calls
laravel · May 13, 2019 · f5d37e4 · f5d37e4
2 parents 3391439 + 0e52e47
commit f5d37e4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Illuminate/Validation/Validator.php b/src/Illuminate/Validation/Validator.php
@@ -267,6 +267,8 @@ public function passes()
 
         $this->distinctValues = [];
 
+        $this->failedRules = [];
+
         // We'll spin through each rule, validating the attributes attached to that
         // rule. Any error messages will be added to the containers with each of
         // the other error messages, returning true if we don't have messages.

diff --git a/tests/Validation/ValidationValidatorTest.php b/tests/Validation/ValidationValidatorTest.php
@@ -4413,6 +4413,14 @@ public function testValidatedNotValidateTwiceData()
         $this->assertEquals(1, $validateCount);
     }
 
+    public function testMultiplePassesCalls()
+    {
+        $trans = $this->getIlluminateArrayTranslator();
+        $v = new Validator($trans, [], ['foo' => 'string|required']);
+        $this->assertFalse($v->passes());
+        $this->assertFalse($v->passes());
+    }
+
     /**
      * @dataProvider validUuidList
      */