Skip to content

[5.8] Fix validation with multiple passes() calls#28502

Merged
taylorotwell merged 1 commit into
laravel:5.8from
staudenmeir:validation
May 13, 2019
Merged

[5.8] Fix validation with multiple passes() calls#28502
taylorotwell merged 1 commit into
laravel:5.8from
staudenmeir:validation

Conversation

@staudenmeir

Copy link
Copy Markdown
Contributor

Validation incorrectly passes after the first time if required isn't the first rule:

$v = Validator::make([], ['foo' => 'required|string']);
dump($v->passes()); // false
dump($v->passes()); // false

$v = Validator::make([], ['foo' => 'string|required']);
dump($v->passes()); // false
dump($v->passes()); // true

We have to reset the $failedRules property every time passes() gets called.

Fixes #28480.

@taylorotwell taylorotwell merged commit f5d37e4 into laravel:5.8 May 13, 2019
@staudenmeir staudenmeir deleted the validation branch May 13, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed form request is allowed to proceed if required is not the first rule

2 participants