Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix validation with multiple passes() calls #28502

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
2 participants
@staudenmeir
Copy link
Contributor

commented May 12, 2019

Validation incorrectly passes after the first time if required isn't the first rule:

$v = Validator::make([], ['foo' => 'required|string']);
dump($v->passes()); // false
dump($v->passes()); // false

$v = Validator::make([], ['foo' => 'string|required']);
dump($v->passes()); // false
dump($v->passes()); // true

We have to reset the $failedRules property every time passes() gets called.

Fixes #28480.

@staudenmeir staudenmeir force-pushed the staudenmeir:validation branch from 2d61c71 to 0e52e47 May 12, 2019

@taylorotwell taylorotwell merged commit f5d37e4 into laravel:5.8 May 13, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@staudenmeir staudenmeir deleted the staudenmeir:validation branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.