Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpoption should be a dependency in Support #51509

Closed
erayaydin opened this issue May 20, 2024 · 1 comment
Closed

Phpoption should be a dependency in Support #51509

erayaydin opened this issue May 20, 2024 · 1 comment

Comments

@erayaydin
Copy link

Laravel Version

11.7.0

PHP Version

8.3

Database Driver & Version

No response

Description

I'm using a custom implementation of Illuminate\Contracts\Foundation\Application and I require illuminate/support. But none of my dependencies dependent phpoption/option. So when I use Illuminate\Support\Env its use Phpoption\Option and Phpoption\Some [1] but illuminate/support doesn't require Phpoption [2].

Are there any specific reason to not require phpoption/phpoption?

[1] https://github.com/illuminate/support/blob/master/Env.php#L7
[2] https://github.com/illuminate/support/blob/master/composer.json

Steps To Reproduce

  • Require illuminate/support in an empty/scratch project.
  • Use env() helper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant