New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Fix Cookie factory to match implementation #23200

Merged
merged 1 commit into from Feb 17, 2018

Conversation

Projects
None yet
2 participants
@laurencei
Member

laurencei commented Feb 17, 2018

There was a change to how the cookie implementation was done a few weeks ago: 530a835#diff-f6e87ec3ac94fefcef2f7979a80a91b1

This implementation has now seperated from the factory interface, and the two are no longer aligned.

This PR brings the factory in line with the required implementation. I've targetted 5.7, because I guess techically this is a change in the interface, so it's a "breaking change"?

Solves #23196.

@taylorotwell taylorotwell merged commit a60770e into laravel:master Feb 17, 2018

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment