Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Option to configure endpoint for DynamoDB #28600

Merged
merged 1 commit into from May 24, 2019

Conversation

Projects
None yet
2 participants
@hmazter
Copy link
Contributor

commented May 24, 2019

This commit adds the option to configure the \Aws\DynamoDb\DynamoDbClient that is used for cache (and session) when using the dynamodb driver.

This is done by passing the endpoint property in the config for cache stores.
When passing null or not passing the property at all the default AWS endpoint is used.
A config for this could look like this:

'dynamodb' => [
    'driver' => 'dynamodb',
    'key' => env('AWS_KEY'),
    'secret' => env('AWS_SECRET'),
    'region' => env('AWS_DEFAULT_REGION', 'eu-north-1'),
    'table' => env('DYNAMODB_CACHE_TABLE', 'cache'),
    'endpoint' => env('DYNAMODB_ENDPOINT', null),
],

The reason for this is to be able to use a local version of DynamoDB for local development and testing.

This does not break any backward compatibility since its an optional property with defaults built into the AWS SDK.

This solves laravel/ideas#1654

Option to configure endpoint for DynamoDB
This commit adds the option to configure the DynamoDBClient that is used for cache
This is done by passing the `endpoint` propery in the config for cache stores.
When passing `null` or not passing the propery at all the default AWS endpoint is used.

This solves laravel/ideas#1654

@GrahamCampbell GrahamCampbell changed the title Option to configure endpoint for DynamoDB [5.8] Option to configure endpoint for DynamoDB May 24, 2019

@taylorotwell taylorotwell merged commit bf7076f into laravel:5.8 May 24, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hmazter hmazter deleted the hmazter:configure-endpoint-for-dynamodb branch May 24, 2019

hmazter added a commit to hmazter/laravel that referenced this pull request May 29, 2019

Add DYNAMODB_ENDPOINT to the cache config
This adds the DYNAMODB_ENDPOINT environment variable to the
dynamodb store of the cache cofig.

Its usage is implemented in the framework as laravel/framework#28600

taylorotwell added a commit to laravel/laravel that referenced this pull request May 29, 2019

Add DYNAMODB_ENDPOINT to the cache config (#5034)
This adds the DYNAMODB_ENDPOINT environment variable to the
dynamodb store of the cache cofig.

Its usage is implemented in the framework as laravel/framework#28600

imabug added a commit to imabug/raddb that referenced this pull request May 30, 2019

Add DYNAMODB_ENDPOINT to the cache config
This adds the DYNAMODB_ENDPOINT environment variable to the
dynamodb store of the cache cofig.

Its usage is implemented in the framework as laravel/framework#28600

realodix added a commit to realodix/urlhub that referenced this pull request May 31, 2019

Add DYNAMODB_ENDPOINT to the cache config
This adds the DYNAMODB_ENDPOINT environment variable to the
dynamodb store of the cache cofig.

Its usage is implemented in the framework as laravel/framework#28600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.