Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Add missing onLastPage to CursorPaginator #42301

Merged
merged 1 commit into from
May 9, 2022
Merged

[9.x] Add missing onLastPage to CursorPaginator #42301

merged 1 commit into from
May 9, 2022

Conversation

rodrigopedra
Copy link
Contributor

Closes #42296

As stated on issue #42296 the docs on CursorPaginator's available methods states it has a onLastPage method, but the implementation of that method is missing on Illuminate\Pagination\CursorPaginator and its parent abstract class.

This PR:

  • Adds the missing onLastPage implementation to Illuminate\Pagination\CursorPaginator
  • Adds a test case covering both onLastPage and onFirstPage

Notes:

@taylorotwell taylorotwell merged commit dc72435 into laravel:9.x May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CursorPaginator::onLastPage method mentioned in docs but does not exist
3 participants