[9.x] Add missing onLastPage to CursorPaginator#42301
Merged
taylorotwell merged 1 commit intolaravel:9.xfrom May 9, 2022
rodrigopedra:9.x
Merged
[9.x] Add missing onLastPage to CursorPaginator#42301taylorotwell merged 1 commit intolaravel:9.xfrom rodrigopedra:9.x
taylorotwell merged 1 commit intolaravel:9.xfrom
rodrigopedra:9.x
Conversation
driesvints
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42296
As stated on issue #42296 the docs on
CursorPaginator's available methods states it has aonLastPagemethod, but the implementation of that method is missing onIlluminate\Pagination\CursorPaginatorand its parent abstract class.This PR:
onLastPageimplementation toIlluminate\Pagination\CursorPaginatoronLastPageandonFirstPageNotes:
onLastPageimplementation is borrowed fromIlluminate\Pagination\AbstractPaginator