Skip to content

[9.x] Add missing onLastPage to CursorPaginator#42301

Merged
taylorotwell merged 1 commit intolaravel:9.xfrom
rodrigopedra:9.x
May 9, 2022
Merged

[9.x] Add missing onLastPage to CursorPaginator#42301
taylorotwell merged 1 commit intolaravel:9.xfrom
rodrigopedra:9.x

Conversation

@rodrigopedra
Copy link
Copy Markdown
Contributor

Closes #42296

As stated on issue #42296 the docs on CursorPaginator's available methods states it has a onLastPage method, but the implementation of that method is missing on Illuminate\Pagination\CursorPaginator and its parent abstract class.

This PR:

  • Adds the missing onLastPage implementation to Illuminate\Pagination\CursorPaginator
  • Adds a test case covering both onLastPage and onFirstPage

Notes:

@taylorotwell taylorotwell merged commit dc72435 into laravel:9.x May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CursorPaginator::onLastPage method mentioned in docs but does not exist

3 participants