[9.x] Add validation rule options: alpha:ascii, alpha_num:ascii, alpha_dash:ascii #45769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of creating new validation rules, it would be better to add an optional ascii option to the existing ones: |
|
Thanks for your code review! |
|
Great thought @tpetry |
taylorotwell
added a commit
to laravel/docs
that referenced
this pull request
Jan 31, 2023
* [9.x] Follow laravel/framework#45769 changes * Correct the definite articles * Avoid ambiguous explanations * Warning about Unicode dashes and underscores * Link to unicode.org * Update validation.md --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
salehhashemi1992
pushed a commit
to salehhashemi1992/docs
that referenced
this pull request
Feb 8, 2023
* [9.x] Follow laravel/framework#45769 changes * Correct the definite articles * Avoid ambiguous explanations * Warning about Unicode dashes and underscores * Link to unicode.org * Update validation.md --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
fuwasegu
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a redo of #45767
Reason for re-submitting PR
The previous PR was closed because it made too many breaking changes to the existing variation rules.
This PR is a new implementation of the validation rules, with no changes to the existing implementation.