[10.x] Add a `Number` utility class #48845

caendesilva · 2023-10-28T08:46:56Z

Abstract

Adds a new Number utility class, in the Illuminate\Support namespace, as suggested by Taylor in #48827 (comment).

use Illuminate\Support\Number;

Number::format(123456789) // 123,456,789
Number::toCurrency(59.99) // $59.99
Number::bytesToHuman(1536) // 1.5 KB
Number::toHuman(10000) // ten thousand

PR Development

The class ports the bytesToHuman() helper from #48827, and after discussion here and in #internals adds some wrappers for the NumberFormatter class. As this requires the php-intl extension, I added a check for those wrappers that throws a RuntimeException. I also added the extension as a suggestion to the Support package composer.json.

Please let me know if this route works, otherwise I'm happy to make changes.

If anyone has ideas on more helpers, please let me know!

Future development

If this gets merged, I'll also make a PR that adds a Numberable (or something better named), similar to Stringable, that allows Number::of(100)->toHuman() and other neat stuff like that.

Ports laravel#48827 into the new `Number` utility class

src/Illuminate/Support/Number.php

caendesilva · 2023-10-29T10:12:16Z

I'm marking this ready for review, as I personally have no more ideas on what utilities to add. But if anyone has ideas I am more than happy to implement!

henzeb · 2023-10-29T10:22:55Z

I'm marking this ready for review, as I personally have no more ideas on what utilities to add. But if anyone has ideas I am more than happy to implement!

https://book.cakephp.org/2/en/core-libraries/helpers/number.html

realodix · 2023-10-29T17:43:10Z

I'm marking this ready for review, as I personally have no more ideas on what utilities to add. But if anyone has ideas I am more than happy to implement!

as suggested by Taylor in #48827 (comment)

number_to_currency, number_to_human, number_to_human_size, number_to_percentage, number_with_delimiter, number_with_precision

caendesilva · 2023-10-29T18:46:49Z

I'm marking this ready for review, as I personally have no more ideas on what utilities to add. But if anyone has ideas I am more than happy to implement!

as suggested by Taylor in #48827 (comment)

number_to_currency, number_to_human, number_to_human_size, number_to_percentage, number_with_delimiter, number_with_precision

Gonna take a stab at a Number::toHuman() helper now!

caendesilva · 2023-10-29T19:12:53Z

src/Illuminate/Support/Number.php

+    /**
+     * Format the number to a fluent human-readable string.
+     *
+     * @param float|int $number
+     * @param string $locale
+     * @return false|string
+     */
+    public static function toHuman($number, $locale = 'en')
+    {
+        $formatter = new NumberFormatter($locale, NumberFormatter::SPELLOUT);
+
+        return $formatter->format($number);
+    }
+


This is unfortunately dependent on the ext-intl, as it wraps the NumberFormatter class. Assuming this is acceptable, we may want to add a check for the extension in the NumberFormatter class, and throw an exception if it is not available. But I understand if this is not worth it. However, given how much code a DIY solution would require, I personally think it is worth it.

If this is acceptable, I'll go right ahead and add some more wrappers as the NumberFormatter class has a lot of useful helpers.

@taylorotwell Hey! Hope it's okay to ping you. Just wanted your opinion regarding wrapping the NumberFormatter class, and how we should handle that.

This is unfortunately dependent on the `ext-intl`, as it wraps the NumberFormatter class.

marcovo · 2023-10-30T11:24:32Z

The use of prefixes in bytesToHuman() seems to follow a custom naming scheme instead of established standards.

I notice two things:

The prefixes used seem to be metrix prefixes (k, M, G, ...), calculating base-10, with the exception that an uppercase K is used instead of the official lowercase k
The calculations seem to be done using base-2, which would actually suggest binary prefixes (Ki, Mi, Gi, ...) should be used

I propose to replace bytesToHuman() with two other methods:

bytesToMetric(), using division by 1000 and using metric abbreviations kB, MB, GB, ...
bytesToBinary() (or some better name), using division by 1024 and using binary abbreviations KiB, MiB, GiB, ...

Other suggestions: toMetricBytes/toBinaryBytes, formatMetricBytes/formatBinaryBytes

caendesilva · 2023-10-30T11:32:43Z

The use of prefixes in bytesToHuman() seems to follow a custom naming scheme instead of established standards.

I notice two things:

The prefixes used seem to be metrix prefixes (k, M, G, ...), calculating base-10, with the exception that an uppercase K is used instead of the official lowercase k

The calculations seem to be done using base-2, which would actually suggest binary prefixes (Ki, Mi, Gi, ...) should be used

I propose to replace bytesToHuman() with two other methods:

bytesToMetric(), using division by 1000 and using metric abbreviations kB, MB, GB, ...

bytesToBinary() (or some better name), using division by 1024 and using binary abbreviations KiB, MiB, GiB, ...

Thank you for the feedback! You are correct that the kB should be lowercase. I will fix that. As for the rest, you are also correct that I am technically using binary abbreviations, as that's what computers use. I realise this makes the method quite opinionated, so let's await some extra feedback on that matter and see what others think.

See laravel#48845 (comment)

marcovo · 2023-10-31T16:33:59Z

I want to stress that the code in the current state uses binary calculations in combination with decimal/metric abbreviations, a combination that would lead to technically confusing results. Do note however, that Windows (up to this date) also does exactly that: it reports filesizes in multiples of 1024 while using metric abbreviations. I would propose to not follow this false windows-path and stick to binary calculations with binary prefixes and/or metric calculations with metric prefixes.

As discussed in #internals, this seems to be a good compromise when the extension is not used. Instead of testing against the exception in the tests, I just skipped the test if the extension is missing, as that is what we do in the InteractsWithRedis testing trait.

caendesilva · 2023-11-01T17:35:30Z

I want to stress that the code in the current state uses binary calculations in combination with decimal/metric abbreviations, a combination that would lead to technically confusing results. Do note however, that Windows (up to this date) also does exactly that: it reports filesizes in multiples of 1024 while using metric abbreviations. I would propose to not follow this false windows-path and stick to binary calculations with binary prefixes and/or metric calculations with metric prefixes.

Noted. I'm considering if we should add an option for if to use base 10 or base 2 but I'm weary of adding a bunch of complexity. Ideally I would like to get input from the core team on what they think is best.

caendesilva · 2023-11-01T17:54:16Z

src/Illuminate/Support/Number.php

@@ -32,7 +32,7 @@ public static function toHuman($number, $locale = 'en')
     */
    public static function bytesToHuman($bytes, $precision = 2)
    {
-        $units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
+        $units = ['B', 'kB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];


There has been some discussion whether we should use kB or KB.

It's worth noting that Rails uses KB. https://api.rubyonrails.org/classes/ActionView/Helpers/NumberHelper.html

khalyomede · 2023-11-04T13:08:11Z

Hi, congratulations on this PR, looks very useful I already can see some home made helpers I could replace by this one.

One question comes to my mind, will the toHuman() method will take into account the locale? I mean this:

$number = Number::of(10);

$number->toCurrency("EUR"); // "€10.00"

App::setLocale("fr");

$number->toCurrency("EUR"); // "10,00 €"

caendesilva · 2023-11-04T13:14:06Z

Hi, congratulations on this PR, looks very useful I already can see some home made helpers I could replace by this one.

One question comes to my mind, will the toHuman() method will take into account the locale? I mean this:
$number = Number::of(10);

$number->toCurrency("EUR"); // "€10.00"

App::setLocale("fr");

$number->toCurrency("EUR"); // "10,00 €" 

Glad you like it! Yes, someone on Twitter pointed this out, so I am just about to implement this.

Edit: See 9cbebdd

tresorkalanda-chd · 2023-11-04T14:31:53Z

I'd also like it to have a helper that allows you to do this without importing the Number class directly.

number()->toHuman();

This makes so that if no locale parameter is specified, the configured App locale is used.

taylorotwell · 2023-11-15T21:06:49Z

Thanks 👍

* Create a new Number utility class * Add a `Number::bytesToHuman()` helper Ports laravel/framework#48827 into the new `Number` utility class * Add a `Number::toHuman()` helper This is unfortunately dependent on the `ext-intl`, as it wraps the NumberFormatter class. * Use lowercase `k` for kilobytes See laravel/framework#48845 (comment) * Update Support package to suggest `ext-intl` * Throw if extension is not installed when using NumberFormatter wrapper As discussed in #internals, this seems to be a good compromise when the extension is not used. Instead of testing against the exception in the tests, I just skipped the test if the extension is missing, as that is what we do in the InteractsWithRedis testing trait. * Add a `Number::toCurrency()` helper * Make Number helper locale parameters null and default to App locale This makes so that if no locale parameter is specified, the configured App locale is used. * Add a `Number::format()` helper Adds a locale-aware number formatting helper * Fix number tests Could not get Mockery to work, so this is my fix. * Add a `Number::toPercent()` helper I'm dividing the supplied value by 100 so that 50 = 50% as that's how Rails does it, and that's what Taylor linked to in his suggestion for this class. The default number formatter would consider 0.5 to be 50% and 50 to be 5000%. I'm not sure which option is best, so I went with the Rails format. https://api.rubyonrails.org/classes/ActionView/Helpers/NumberHelper.html#method-i-number_to_percentage * Rename Number toHuman helper to spellout We may want to remove it, as per laravel/framework#48845 (comment). But renaming it for now. * Create new `Number::toHuman()` helper Based on the Rails implementation, as requested by Taylor in laravel/framework#48845 (comment) See https://api.rubyonrails.org/classes/ActionView/Helpers/NumberHelper.html#method-i-number_to_human Uses the short scale system, see https://en.wikipedia.org/wiki/Long_and_short_scales * Change toHuman implementation to better match Rails version Based more on the logic of Rails, but with added support for massive numbers. * Update toHuman helper to better handle extreme numbers Inverts negative numbers, and removes unreachable cases, and handles very large numbers * Clean up toHuman helper * formatting * formatting * formatting * formatting * formatting --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>

OzanKurt · 2023-11-16T20:35:35Z

src/Illuminate/Support/Number.php

+     * @param  int  $precision
+     * @return string
+     */
+    public static function forHumans(int|float $number, int $precision = 0)


What about other languages?

Hmm, maybe the __() function could be used to provide translation support?

#48845 (comment)

Building on laravel#48845, this class will work similarly to the `Stringable` class, but for numbers.

rmunate · 2023-11-18T15:16:23Z

@caendesilva @taylorotwell Hello Engineers, I would like to take into account the following comment, I would like to add a functionality that is called Number::spell() and that this returns an instance of my package "https://github.com/rmunate/SpellNumber" to translate to letters, to currency format and to ordinals.

I would like to be able to contemplate it, it would be something like this

Number::spell(100)->locale('en')->toLetters();
// "One Hundred"

Number::spell(100)->locale('es')->toLetters();
// "Cien"

Number::spell(100)->locale('fa')->toLetters();
// "صد"

Number::spell(100)->locale('hi')->toLetters();
// "एक सौ"

Number::spell((123456789.12)->locale('en')->toLetters();
// "One Hundred Twenty-Three Million Four Hundred Fifty-Six Thousand Seven Hundred Eighty-Nine And Twelve"

Number::spell(2)->locale('en')->toOrdinal();
// "Second"

Number::spell(2)->locale('en')->toOrdinal(SpellNumber::ORDINAL_DEFAULT);
// "Second"

Number::spell(2)->locale('es')->toOrdinal(SpellNumber::ORDINAL_MALE);
// "Segundo"

Number::spell(2)->locale('es')->toOrdinal(SpellNumber::ORDINAL_FEMALE);
// "Segunda"

//etc

See docs : https://rmunate.github.io/SpellNumber/

what do you think? Do you want me to work on adjusting this?

I could commit to refining the package to seamlessly integrate with the solution you've implemented. Furthermore, it doesn't solely cater to English; we are enhancing its internationalization capabilities. Additionally, the handling of ordinals varies across languages, and this aspect has already been addressed.

@OzanKurt @utsavsomaiya @tresorkalanda-chd @khalyomede @marcovo @realodix @henzeb

rmunate · 2023-11-18T15:33:20Z

I think the human implementation is a bit better in Rails. This one where it totally spells out the word doesn't feel immediately useful.

#48845 (comment)

caendesilva · 2023-11-18T15:48:42Z

@caendesilva @taylorotwell Hello Engineers, I would like to take into account the following comment, I would like to add a functionality that is called Number::spell() and that this returns an instance of my package "https://github.com/rmunate/SpellNumber" to translate to letters, to currency format and to ordinals.

I'm not a maintainer so take this with a grain of salt, but I think what you are proposing would add too much complexity to be in the core framework, as most people don't need advanced spellout helpers, and those that do can use your package. Remember that this Number utility class is macroable, so your package could be updated to extend this class with your methods.

andrey-helldar · 2023-11-20T17:35:30Z

It's fine for basic use, but if you need more flexible localization support, it's better to use the kwn/number-to-words package.

TursunboyevJahongir · 2023-11-20T21:08:56Z

this function works great, but can we use it with locate ?

Number::toHuman(1000, 'en') //1 thousand
Number::toHuman(1000, 'fr') //1 mille

jtibbles · 2023-11-22T19:58:43Z

Hi, great work. However, regarding German formatting:
Number::toCurrency(5.49, currency: 'EUR', locale: 'de') // 5.49

....in Germany (de_de) and Austria (de_at) they use a comma, not a dot. €5.49 is actually displayed as "€5,49".
Naturally it's always stored in a DB table with a dot (unless it's stored as a string) and converted to a dot for calculations.
Is there any chance this can be amended in a future update?

caendesilva · 2023-11-22T20:00:17Z

this function works great, but can we use it with locate ?
Number::toHuman(1000, 'en') //1 thousand
Number::toHuman(1000, 'fr') //1 mille

I like the idea and am gonna play around with it when I have some time over!

caendesilva · 2023-11-22T20:02:02Z

Hi, great work. However, regarding German formatting: Number::toCurrency(5.49, currency: 'EUR', locale: 'de') // 5.49

....in Germany (de_de) and Austria (de_at) they use a comma, not a dot. €5.49 is actually displayed as "€5,49". Naturally it's always stored in a DB table with a dot (unless it's stored as a string) and converted to a dot for calculations. Is there any chance this can be amended in a future update?

Are you able to specify de_de/de_at as the locale? If those are incorrect, then this would be an bug in the upstream PHP extension.

jtibbles · 2023-11-22T20:29:32Z

You can specify those and others that use the same format (cs_CZ for example). It's possible in the php.ini (setlocale(LC_MONETARY, 'cs_CZ') ). But many of my projects now expect multiple language packs now so while the amount and currency symbol stays the same, the formatting needs to be swapped out on the fly. Changing the locale for this is a bit cumbersome. If toCurrency can handle it instead it takes some weight off.
There's always str_replace I guess

caendesilva · 2023-11-22T20:35:24Z

You can specify those and others that use the same format (cs_CZ for example). It's possible in the php.ini (setlocale(LC_MONETARY, 'cs_CZ') ). But many of my projects now expect multiple language packs now so while the amount and currency symbol stays the same, the formatting needs to be swapped out on the fly. Changing the locale for this is a bit cumbersome. If toCurrency can handle it instead it takes some weight off. There's always str_replace I guess

You should probably be able to add a service provider or middleware to automatically set the Number::useLocale() to the request user's locale.

## Abstract This has been requested by a large number of people after laravel#48845. My attempt at implementing localization support for this method is using translation helpers. ## Example ```php // Example language setup 'sv' => [ 'thousand' => 'tusen', 'million' => 'miljon', 'billion' => 'miljard', 'trillion' => 'biljon', 'quadrillion' => 'biljard', ], ```

This has been requested by a large number of people after laravel#48845. My attempt at implementing localization support for this method is using translation helpers. ```php // Example language setup 'sv' => [ 'thousand' => 'tusen', 'million' => 'miljon', 'billion' => 'miljard', 'trillion' => 'biljon', 'quadrillion' => 'biljard', ], ```

[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [laravel/framework](https://laravel.com) ([source](https://togithub.com/laravel/framework)) | `10.30.1` -> `10.33.0` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/laravel%2fframework/10.33.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/laravel%2fframework/10.33.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/laravel%2fframework/10.30.1/10.33.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/laravel%2fframework/10.30.1/10.33.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>laravel/framework (laravel/framework)</summary> ### [`v10.33.0`](https://togithub.com/laravel/framework/blob/HEAD/CHANGELOG.md#v10330---2023-11-21) [Compare Source](https://togithub.com/laravel/framework/compare/v10.32.1...v10.33.0) - \[10.x] Fix wrong parameter passing and add these rules to dependent rules by [@kayw-geek](https://togithub.com/kayw-geek) in [laravel/framework#49008 - \[10.x] Make Validator::getValue() public by [@shinsenter](https://togithub.com/shinsenter) in [laravel/framework#49007 - \[10.x] Custom messages for `Password` validation rule by [@rcknr](https://togithub.com/rcknr) in [laravel/framework#48928 - \[10.x] Round milliseconds in database seeder console output runtime by [@SjorsO](https://togithub.com/SjorsO) in [laravel/framework#49014 - \[10.x] Add a `Number` utility class by [@caendesilva](https://togithub.com/caendesilva) in [laravel/framework#48845 - \[10.x] Fix the replace() method in DefaultService class by [@jonagoldman](https://togithub.com/jonagoldman) in [laravel/framework#49022 - \[10.x] Pass the property $validator as a parameter to the $callback Closure by [@shinsenter](https://togithub.com/shinsenter) in [laravel/framework#49015 - \[10.x] Fix Cache DatabaseStore::add() error occur on Postgres within transaction by [@xdevor](https://togithub.com/xdevor) in [laravel/framework#49025 - \[10.x] Support asserting against chained batches by [@taylorotwell](https://togithub.com/taylorotwell) in [laravel/framework#49003 - \[10.x] Prevent DB `Cache::get()` occur race condition by [@xdevor](https://togithub.com/xdevor) in [laravel/framework#49031 - \[10.x] Fix notifications being counted as sent without a "shouldSend" method by [@joelwmale](https://togithub.com/joelwmale) in [laravel/framework#49030 - \[10.x] Fix tests failure on Windows by [@hafezdivandari](https://togithub.com/hafezdivandari) in [laravel/framework#49037 - \[10.x] Add unless conditional on validation rules by [@michaelnabil230](https://togithub.com/michaelnabil230) in [laravel/framework#49048 - \[10.x] Handle string based payloads that are not JSON or form data when creating PSR request instances by [@timacdonald](https://togithub.com/timacdonald) in [laravel/framework#49047 - \[10.x] Fix directory separator CMD display on windows by [@imanghafoori1](https://togithub.com/imanghafoori1) in [laravel/framework#49045 - \[10.x] Fix mapSpread doc by [@timacdonald](https://togithub.com/timacdonald) in [laravel/framework#48941 - \[10.x] Tiny `Support\Collection` test fix - Unused data provider parameter by [@stevebauman](https://togithub.com/stevebauman) in [laravel/framework#49053 - \[10.x] Feat: Add color_hex validation rule by [@nikopeikrishvili](https://togithub.com/nikopeikrishvili) in [laravel/framework#49056 - \[10.x] Handle missing translation strings using callback by [@DeanWunder](https://togithub.com/DeanWunder) in [laravel/framework#49040 - \[10.x] Add Str::transliterate to Stringable by [@dwightwatson](https://togithub.com/dwightwatson) in [laravel/framework#49065 - Add Alpha Channel support to Hex validation rule by [@ahinkle](https://togithub.com/ahinkle) in [laravel/framework#49069 ### [`v10.32.1`](https://togithub.com/laravel/framework/blob/HEAD/CHANGELOG.md#v10321---2023-11-14) [Compare Source](https://togithub.com/laravel/framework/compare/v10.32.0...v10.32.1) - \[10.x] Add `[@pushElseIf](https://togithub.com/pushElseIf)` and `[@pushElse](https://togithub.com/pushElse)` by [@jasonmccreary](https://togithub.com/jasonmccreary) in [laravel/framework#48990 ### [`v10.32.0`](https://togithub.com/laravel/framework/blob/HEAD/CHANGELOG.md#v10320---2023-11-14) [Compare Source](https://togithub.com/laravel/framework/compare/v10.31.0...v10.32.0) - Update PendingRequest.php by [@mattkingshott](https://togithub.com/mattkingshott) in [laravel/framework#48939 - \[10.x] Change array_key_exists with null coalescing assignment operator in FilesystemAdapter by [@miladev95](https://togithub.com/miladev95) in [laravel/framework#48943 - \[10.x] Use container to resolve email validator class by [@orkhanahmadov](https://togithub.com/orkhanahmadov) in [laravel/framework#48942 - \[10.x] Added `getGlobalMiddleware` method to HTTP Client Factory by [@pascalbaljet](https://togithub.com/pascalbaljet) in [laravel/framework#48950 - \[10.x] Detect MySQL read-only mode error as a lost connection by [@cosmastech](https://togithub.com/cosmastech) in [laravel/framework#48937 - \[10.x] Adds more implicit validation rules for `present` based on other fields by [@diamondobama](https://togithub.com/diamondobama) in [laravel/framework#48908 - \[10.x] Refactor set_error_handler callback to use arrow function in `InteractsWithDeprecationHandling` by [@miladev95](https://togithub.com/miladev95) in [laravel/framework#48954 - \[10.x] Test Improvements by [@crynobone](https://togithub.com/crynobone) in [laravel/framework#48962 - Fix issue that prevents BladeCompiler to raise an exception when temporal compiled blade template is not found. by [@juanparati](https://togithub.com/juanparati) in [laravel/framework#48957 - \[10.x] Fix how nested transaction callbacks are handled by [@mateusjatenee](https://togithub.com/mateusjatenee) in [laravel/framework#48859 - \[10.x] Fixes Batch Callbacks not triggering if job timeout while in transaction by [@crynobone](https://togithub.com/crynobone) in [laravel/framework#48961 - \[10.x] expressions in migration computations fail by [@tpetry](https://togithub.com/tpetry) in [laravel/framework#48976 - \[10.x] Fixes Exception: Cannot traverse an already closed generator when running Arr::first with an empty generator and no callback by [@moshe-autoleadstar](https://togithub.com/moshe-autoleadstar) in [laravel/framework#48979 - fixes issue with stderr when there was "]" character. by [@nikopeikrishvili](https://togithub.com/nikopeikrishvili) in [laravel/framework#48975 - \[10.x] Fix Postgres cache store failed to put exist cache in transaction by [@xdevor](https://togithub.com/xdevor) in [laravel/framework#48968 ### [`v10.31.0`](https://togithub.com/laravel/framework/blob/HEAD/CHANGELOG.md#v10310---2023-11-07) [Compare Source](https://togithub.com/laravel/framework/compare/v10.30.1...v10.31.0) - \[10.x] Allow `Sleep::until()` to be passed a timestamp as a string by [@jameshulse](https://togithub.com/jameshulse) in [laravel/framework#48883 - \[10.x] Fix whereHasMorph() with nullable morphs by [@MarkKremer](https://togithub.com/MarkKremer) in [laravel/framework#48903 - \[10.x] Handle `class_parents` returning false in `class_uses_recursive` by [@RoflCopter24](https://togithub.com/RoflCopter24) in [laravel/framework#48902 - \[10.x] Enable default retrieval of all fragments in `fragments()` and `fragmentsIf()` methods by [@tabuna](https://togithub.com/tabuna) in [laravel/framework#48894 - \[10.x] Allow placing a batch on a chain by [@khepin](https://togithub.com/khepin) in [laravel/framework#48633 - \[10.x] Dispatch 'connection failed' event in async http client request by [@gdebrauwer](https://togithub.com/gdebrauwer) in [laravel/framework#48900 - authenticate method refactored to use null coalescing operator by [@miladev95](https://togithub.com/miladev95) in [laravel/framework#48917 - \[10.x] Add support for Sec-Purpose header by [@nanos](https://togithub.com/nanos) in [laravel/framework#48925 - \[10.x] Allow setting retain_visibility config option on Flysystem filesystems by [@jnoordsij](https://togithub.com/jnoordsij) in [laravel/framework#48935 - \[10.x] Escape forward slashes when exploding wildcard rules by [@matt-farrugia](https://togithub.com/matt-farrugia) in [laravel/framework#48936 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lapotor/RadioRoster-api).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

WikiRik · 2023-11-28T19:19:11Z

@taylorotwell it seems that a part of the functionality was lost in one of your formatting commits; 6d3a6c2
Before this commit it used App::getLocale() to retrieve the default locale of the app and now it only has a new method called useLocale. Can you elaborate on why this change was made? Before people open a PR that adds the functionality to use the globally set locale (like was expected by Povilas of Laravel Daily in this video; https://www.youtube.com/watch?v=PRhhqukK9uw )

caendesilva · 2023-11-28T19:31:51Z

@taylorotwell it seems that a part of the functionality was lost in one of your formatting commits; 6d3a6c2 Before this commit it used App::getLocale() to retrieve the default locale of the app and now it only has a new method called useLocale. Can you elaborate on why this change was made? Before people open a PR that adds the functionality to use the globally set locale (like was expected by Povilas of Laravel Daily in this video; https://www.youtube.com/watch?v=PRhhqukK9uw )

Thanks for bringing this up! I've been wondering this too, especially since it's something I've been asked about a bunch.

andrersilva96 · 2023-12-29T17:18:12Z

Hi @caendesilva I was testing with brazilian currency, I believe that we use comma to separate decimals and dot for thousands:
R$11,000.36 // \Illuminate\Support\Number::currency(11000.36, 'BRL')
R$ 11.000,36 // using my own helper

caendesilva · 2023-12-29T18:02:32Z

Hi @caendesilva I was testing with brazilian currency, I believe that we use comma to separate decimals and dot for thousands: R$11,000.36 // \Illuminate\Support\Number::currency(11000.36, 'BRL') R$ 11.000,36 // using my own helper

Hey, @andrersilva96 thanks for bringing it up! So I took a quick look, and does seem like the Brazilian reals are indeed divided using commas (inverted behaviour compared to the US dollar formatting). Though I did not in my brief search find an official source.

However, this helper is a wrapper for the PHP Intl extension, so this means that the bug is present in the PHP Core and needs to be fixed there. I suggest you file a bug report through here https://www.php.net/manual/en/install.problems.bugs.php. Feel free to ping me in the report!

becker · 2024-01-19T13:18:06Z

@andrersilva96, I believe you could do this way:

Number::currency(11000.36, 'BRL', 'pt_BR')
// "R$ 11.000,36"

andrersilva96 · 2024-01-23T00:58:57Z

@becker This worked, thank's a lot ou melhor obrigado meu conterrâneo! haha

caendesilva added 2 commits October 28, 2023 10:42

Create a new Number utility class

b5fb4a9

Add a Number::bytesToHuman() helper

fb0e6ce

Ports laravel#48827 into the new `Number` utility class

caendesilva commented Oct 28, 2023

View reviewed changes

src/Illuminate/Support/Number.php Show resolved Hide resolved

caendesilva changed the title ~~[10.x] Add a helperNumber utility class~~ [10.x] Add a Number utility class Oct 28, 2023

LasseRafn mentioned this pull request Oct 28, 2023

[10.x] Fix Stringable objects not converted to string in HTTP facade Query parameters and Body #48849

Merged

caendesilva marked this pull request as ready for review October 29, 2023 10:11

caendesilva marked this pull request as draft October 29, 2023 18:46

caendesilva commented Oct 29, 2023

View reviewed changes

Add a Number::toHuman() helper

66655b4

This is unfortunately dependent on the `ext-intl`, as it wraps the NumberFormatter class.

caendesilva force-pushed the number-utility-class branch from 7cfa92a to 66655b4 Compare October 29, 2023 19:14

Use lowercase k for kilobytes

8290812

See laravel#48845 (comment)

caendesilva added 2 commits November 1, 2023 18:25

Update Support package to suggest ext-intl

21ed5e0

caendesilva force-pushed the number-utility-class branch from 4520eb2 to d59942b Compare November 1, 2023 17:33

Add a Number::toCurrency() helper

8151a80

caendesilva commented Nov 1, 2023

View reviewed changes

andrius-386 mentioned this pull request Nov 3, 2023

[10.x] Add Number class; convert given number to percentage. #48909

Closed

caendesilva force-pushed the number-utility-class branch from ada871a to 9cbebdd Compare November 4, 2023 13:20

Make Number helper locale parameters null and default to App locale

9a2704f

This makes so that if no locale parameter is specified, the configured App locale is used.

formatting

cf1bc44

taylorotwell merged commit 6e4ecc7 into laravel:10.x Nov 15, 2023
20 checks passed

ahinkle mentioned this pull request Nov 16, 2023

[10.x] Add Number Utility laravel/docs#9141

Merged

OzanKurt reviewed Nov 16, 2023

View reviewed changes

caendesilva added a commit to caendesilva/laravel-framework that referenced this pull request Nov 17, 2023

Create a new Numberable helper

ffed3a9

Building on laravel#48845, this class will work similarly to the `Stringable` class, but for numbers.

caendesilva mentioned this pull request Nov 17, 2023

[10.x] Add a new Numberable helper #49036

Closed

4 tasks

caendesilva added a commit to caendesilva/laravel-framework that referenced this pull request Nov 17, 2023

Create a new Numberable helper

f44217a

Building on laravel#48845, this class will work similarly to the `Stringable` class, but for numbers.

caendesilva mentioned this pull request Nov 23, 2023

[10.x] Add localization support to the Number::forHumans helper #49106

Closed

marcovo mentioned this pull request Nov 24, 2023

Fix byte formatting abbreviations to use established standards #49115

Closed

[10.x] Add a Number utility class #48845

[10.x] Add a Number utility class #48845

Conversation

caendesilva commented Oct 28, 2023 • edited

Abstract

PR Development

Future development

caendesilva commented Oct 29, 2023

henzeb commented Oct 29, 2023

realodix commented Oct 29, 2023 • edited

caendesilva commented Oct 29, 2023

caendesilva Oct 29, 2023

Choose a reason for hiding this comment

caendesilva Oct 29, 2023

Choose a reason for hiding this comment

caendesilva Oct 30, 2023

Choose a reason for hiding this comment

marcovo commented Oct 30, 2023 • edited

caendesilva commented Oct 30, 2023

marcovo commented Oct 31, 2023

caendesilva commented Nov 1, 2023

caendesilva Nov 1, 2023 • edited

Choose a reason for hiding this comment

khalyomede commented Nov 4, 2023

caendesilva commented Nov 4, 2023 • edited

tresorkalanda-chd commented Nov 4, 2023

taylorotwell commented Nov 15, 2023

OzanKurt Nov 16, 2023

Choose a reason for hiding this comment

caendesilva Nov 16, 2023

Choose a reason for hiding this comment

rmunate Nov 18, 2023

Choose a reason for hiding this comment

rmunate commented Nov 18, 2023 • edited

rmunate commented Nov 18, 2023

caendesilva commented Nov 18, 2023

andrey-helldar commented Nov 20, 2023

TursunboyevJahongir commented Nov 20, 2023

jtibbles commented Nov 22, 2023

caendesilva commented Nov 22, 2023

caendesilva commented Nov 22, 2023

jtibbles commented Nov 22, 2023 • edited

caendesilva commented Nov 22, 2023

WikiRik commented Nov 28, 2023

caendesilva commented Nov 28, 2023

andrersilva96 commented Dec 29, 2023

caendesilva commented Dec 29, 2023

becker commented Jan 19, 2024

andrersilva96 commented Jan 23, 2024

[10.x] Add a `Number` utility class #48845

[10.x] Add a `Number` utility class #48845

caendesilva commented Oct 28, 2023 •

edited

realodix commented Oct 29, 2023 •

edited

marcovo commented Oct 30, 2023 •

edited

caendesilva Nov 1, 2023 •

edited

caendesilva commented Nov 4, 2023 •

edited

rmunate commented Nov 18, 2023 •

edited

jtibbles commented Nov 22, 2023 •

edited