[10.x] Allow setting retain_visibility config option on Flysystem filesystems

[jnoordsij]

This config option was introduced in version 3.19.0; see also https://github.com/thephpleague/flysystem/blob/3.19.0/CHANGELOG.md#3190---2023-11-07 and thephpleague/flysystem#1721.

[kyranb]

@jnoordsij @driesvints

flysystem says in their changelog that:

Default visibility options are ignored when moving/copying while respecting visibility retention settings.

Does this change affect existing Laravel applications that copy or move files without setting retain_visibility as true? Should Laravel maintain its current behaviour (up until this release of flysystem) of preserving file visibility by default?

Or maybe just draw more attention to this change?

[driesvints]

@kyranb hmm, I wouldn't expect things to suddenly change here as that's a breaking change in flysystem itself them. Did you notice things changing for you when we launched this change?

[jnoordsij]

If you check the PR (see thephpleague/flysystem#1721) you can see the default behavior of Flysystem was not changed: it was already retaining visibility by default and still is. The only change is that you can now actually toggle off this behavior if you want to.

Note: there have been some other recent PRs related to visibility by myself as well, which do ensure that

• retaining visibility works more consistently for Filesystem instances (see Ignore visibility by default on copy/move in Filesystem thephpleague/flysystem#1724), which are used internally by Laravel and thus might cause changes in behavior;
• retaining visibility is also done by default now on LocalAdapter instances (see Use visibility on copy/move operations in local adapter thephpleague/flysystem#1723 and Retain file visibility when copying in LocalAdapter thephpleague/flysystem#1730).