-
Notifications
You must be signed in to change notification settings - Fork 28
[Proposal] replace Carbon with Date #675
Comments
@Evertt why don't you use macros, as |
I also think #362 is a much much better choice. Also replacing Carbon should only be done in a major release like Laravel 6. |
I'm against any change that would increase the dependency on Carbon in any way, this is one of those changes. People will get used to these new method and will then have trouble converting to another datetime library. Carbon cannot be trusted with your timezone management. We must migrate away from Carbon. briannesbitt/Carbon#863 |
Well not if the replacement extends Carbon, right? Because that means that all code that was depending on Carbon still works. Anyhow, yeah I like |
Extending Carbon is a bad idea. Carbon isn't maintained anymore which means that the longer you wait with replacing it the harder it will be to do so in the future. You shouldn't rely on 3rd-party code that isn't maintained anymore. It's best to bite the bullet and replace it with a better and maintained alternative. |
Any interest in a PR to do this? |
@davidstanley01 unless Taylor decides that this can be done I don't think it's worth the effort. Next release is 5.6 so it won't be for that release. |
This Date package from jenssegers extends Carbon by adding localized methods to it.
I would love this package to become Laravel's default package. Since it extends Carbon, that means that any function that was made for Carbon doesn't have to change immediately.
Laravel 5.5 could completely switch to Date and all the projects that migrate to 5.5 and use Carbon wouldn't break. I say let's do that.
The text was updated successfully, but these errors were encountered: