[2.x] Exclude hidden inputs from focusable elements #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
|
When investigating this I've come across other situations where certain elements may break the tabbing, for example with the It's clearly outside the scope of this PR, let me know if you want me to open an issue and propose a solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if there is any
<input type="hidden">inside the modal, tabbing stops when that element is next.This PR excludes such hidden inputs via the query-selector, so that focus progression is no longer stopped.
I couldn't find any existing tests for the modal or its tabbing in this repo, so I haven't updated or added any tests.