Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add x-trap #225

Merged
merged 4 commits into from
Oct 11, 2022
Merged

feature: add x-trap #225

merged 4 commits into from
Oct 11, 2022

Conversation

Silver343
Copy link
Contributor

Hi This pull requests adds alpines x-trap to handle the focus for models.

It is my understanding that the alpine plugins do not work with Alpine v2 and therefore it could no longer be supported.

@PhiloNL PhiloNL merged commit 71a65ef into wire-elements:main Oct 11, 2022
@Silver343 Silver343 deleted the feature/Add-x-trap branch October 11, 2022 15:58
@dtorras
Copy link
Contributor

dtorras commented Feb 17, 2023

@PhiloNL while these changes are not published in a new release, would you like to publish a minor release fixing it like Jetstream before using x-trap? laravel/jetstream#757

I can create the PR

@PhiloNL
Copy link
Contributor

PhiloNL commented Feb 18, 2023

Hi @dtorras
Feel free to create a PR. This will be a mayor release, though as it is a breaking change given it requires an additional alpine plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants