-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.x] DRY up path to /home #5173
Conversation
Maybe a method would be better, like the |
I agree to @Lloople that |
Would it be ok if the |
This solution uses the Route Service Provider, if someone needs to add some logic to the home route, like me, we could use a custom service provider or helper to return the proper string in the controllers we need it. |
@sertxudeveloper You mean replacing all code occurrences of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much yes!
@Lloople Yes, I would have no problem in modifying it with a custom method in the places where I need it. |
@Lloople you can still override the |
Still prefer a named route for this. |
How does this benefit?
Yeah, but what's easier... changing the $redirectTo or changing the $redirectTo & service provider? -- Is this change documented anywhere so I can read up on the benefits? Thanks |
I would very much prefer the |
We were defining this path in six places (!).