Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Bump Dependencies and run Tests on skeleton #240

Merged
merged 5 commits into from
Jan 9, 2024
Merged

[1.x] Bump Dependencies and run Tests on skeleton #240

merged 5 commits into from
Jan 9, 2024

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Jan 9, 2024

Replaces #232

@Jubeki
Copy link
Contributor Author

Jubeki commented Jan 9, 2024

@nunomaduro I tested with the available options, but a change in the skeleton would be necessary (or removing the rule fully_qualified_strict_types would also be an option.)

Here the documentation of the rule fully_qualified_strict_types
https://cs.symfony.com/doc/rules/import/fully_qualified_strict_types.html

The failing tests are here, because I also added the skeleton to the test workflow.

@Jubeki
Copy link
Contributor Author

Jubeki commented Jan 9, 2024 •
edited

The changes in the skeleton would be regarding the imported middleware in app/Http/Kernel.php due to the namespace of the Middleware being a subnamespace of App\Http.

- \App\Http\Middleware\Authenticate::class,
+ Middleware\Authenticate::class,

See Results/changes here: https://github.com/Jubeki/laravel-code-style/actions/runs/7454679874/job/20282449218

@Jubeki Jubeki changed the title Update Dependencies and run Tests on skeleton [1.x] Update Dependencies and run Tests on skeleton Jan 9, 2024
@Jubeki Jubeki changed the title [1.x] Update Dependencies and run Tests on skeleton [1.x] Bump Dependencies and run Tests on skeleton Jan 9, 2024
@nunomaduro nunomaduro marked this pull request as ready for review January 9, 2024 11:12
@taylorotwell taylorotwell merged commit 2500d9d into laravel:main Jan 9, 2024
6 checks passed
@Jubeki Jubeki deleted the update branch January 9, 2024 11:31
renovate bot added a commit to RadioRoster/backend that referenced this pull request Feb 10, 2024
@renovate
chore(deps): update dependency laravel/pint to v1.13.10 (#118)
f807834 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [laravel/pint](https://laravel.com)
([source](https://togithub.com/laravel/pint)) | `1.13.7` -> `1.13.10` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/laravel%2fpint/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/laravel%2fpint/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/laravel%2fpint/1.13.7/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/laravel%2fpint/1.13.7/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>laravel/pint (laravel/pint)</summary>

###
[`v1.13.10`](https://togithub.com/laravel/pint/blob/HEAD/CHANGELOG.md#v11310---2024-01-22)

[Compare
Source](https://togithub.com/laravel/pint/compare/v1.13.9...v1.13.10)

- Bump Dependencies and fix spacing issue by
[@&#8203;Jubeki](https://togithub.com/Jubeki) in
[laravel/pint#244

###
[`v1.13.9`](https://togithub.com/laravel/pint/blob/HEAD/CHANGELOG.md#v1139---2024-01-16)

[Compare
Source](https://togithub.com/laravel/pint/compare/v1.13.8...v1.13.9)

- \[1.x] Replace custom phpdoc_align rule with php-cs-fixer option by
[@&#8203;Jubeki](https://togithub.com/Jubeki) in
[laravel/pint#242

###
[`v1.13.8`](https://togithub.com/laravel/pint/blob/HEAD/CHANGELOG.md#v1138---2024-01-09)

[Compare
Source](https://togithub.com/laravel/pint/compare/v1.13.7...v1.13.8)

- \[1.x] Bump Dependencies and run Tests on skeleton by
[@&#8203;Jubeki](https://togithub.com/Jubeki) in
[laravel/pint#240

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/RadioRoster/backend).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jubeki @taylorotwell @nunomaduro