-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Replace custom phpdoc_align rule with php-cs-fixer option #242
Conversation
Jubeki
commented
Jan 15, 2024
•
edited
Loading
edited
- Replaces custom phpdoc_align rule with php-cs-fixer option
- This also adds an additional test case
- Fixes tests, the output for check style is now different:
- format code with the new pint version.
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
@eusonlito What exactly is your comment about? |
@Jubeki after updating to the latest release I got an error I had this rule as |
Well, since updating from 1.13.8 to 1.13.9 I've been having issues with pint no being able to fix my issues.
An error from one of the files are:
Only change I did to my files was to remove the Other who has issues with this? |
@phh probably something with another php-cs-fixer rule. I will send another PR, which bumps the php-cs-fixer version to the patch which was released. |
@phh can you send a code snippet, so that I can confirm if the new patch version would work? |
@Jubeki Could reproduce on a fresh laravel app with: pint.json:
app/Models/TestModel.php
|
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [laravel/pint](https://laravel.com) ([source](https://togithub.com/laravel/pint)) | `1.13.7` -> `1.13.10` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/laravel%2fpint/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/laravel%2fpint/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/laravel%2fpint/1.13.7/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/laravel%2fpint/1.13.7/1.13.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>laravel/pint (laravel/pint)</summary> ### [`v1.13.10`](https://togithub.com/laravel/pint/blob/HEAD/CHANGELOG.md#v11310---2024-01-22) [Compare Source](https://togithub.com/laravel/pint/compare/v1.13.9...v1.13.10) - Bump Dependencies and fix spacing issue by [@​Jubeki](https://togithub.com/Jubeki) in [laravel/pint#244 ### [`v1.13.9`](https://togithub.com/laravel/pint/blob/HEAD/CHANGELOG.md#v1139---2024-01-16) [Compare Source](https://togithub.com/laravel/pint/compare/v1.13.8...v1.13.9) - \[1.x] Replace custom phpdoc_align rule with php-cs-fixer option by [@​Jubeki](https://togithub.com/Jubeki) in [laravel/pint#242 ### [`v1.13.8`](https://togithub.com/laravel/pint/blob/HEAD/CHANGELOG.md#v1138---2024-01-09) [Compare Source](https://togithub.com/laravel/pint/compare/v1.13.7...v1.13.8) - \[1.x] Bump Dependencies and run Tests on skeleton by [@​Jubeki](https://togithub.com/Jubeki) in [laravel/pint#240 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/RadioRoster/backend). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>