Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sail:install creates invalid Yaml files when using mysql. #566

Closed
pacoorozco opened this issue Mar 21, 2023 · 4 comments
Closed

sail:install creates invalid Yaml files when using mysql. #566

pacoorozco opened this issue Mar 21, 2023 · 4 comments
Labels

Comments

@pacoorozco
Copy link

  • Sail Version: 1.21.2
  • Laravel Version: 10.3.3
  • PHP Version: 8.1.2
  • Host operating system: Linux kUbuntu 22.04.2

Description:

When running the php artisan sail:install and choosing mysql as a service, the docker-compose.yml is invalid.

The invalid part is:

        healthcheck:
            test:
                - CMD
                - mysqladmin
                - ping
                - '-p${DB_PASSWORD}'
            retries: 3

Instead of the one that's included in the stub

        test: ["CMD", "mysqladmin", "ping", "-p${DB_PASSWORD}"]

I guess the same happens with other services such as pgsql.

Steps To Reproduce:

  1. composer require laravel/sail --dev
  2. php artisan sail:install, choose mysql as a service (option 0)
  3. View the new created docker-compose.yml file.
@driesvints
Copy link
Member

@tonysm this looks like something from your PR #532. Is there a way we can fix this?

@driesvints driesvints added the bug label Mar 21, 2023
@tonysm
Copy link
Contributor

tonysm commented Mar 21, 2023

@driesvints Yep. That was from that PR.

Hey, @pacoorozco, what do you mean by invalid? I'm using that same format, and it seems to work. 🤔

@pacoorozco
Copy link
Author

I've tried again and it's working, although my IDE does not like this format very much, so It was a false alarm... Sorry 🙏🏼

@driesvints
Copy link
Member

Thanks @tonysm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants