add ffmpeg to support videos, when using Spatie media-library for Videos #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patie media-library for Videos.
itinerare
pushed a commit
to itinerare/Alcyone
that referenced
this pull request
Feb 26, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [laravel/sail](https://github.com/laravel/sail) | `1.27.4` -> `1.28.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>laravel/sail (laravel/sail)</summary> ### [`v1.28.0`](https://github.com/laravel/sail/blob/HEAD/CHANGELOG.md#v1280---2024-02-20) [Compare Source](laravel/sail@v1.27.4...v1.28.0) - Changing pcov Directory by [@​joaopalopes24](https://github.com/joaopalopes24) in laravel/sail#670 - add ffmpeg to support videos, when using Spatie media-library for Videos by [@​negoziator](https://github.com/negoziator) in laravel/sail#671 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTQuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxNC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Reviewed-on: https://code.itinerare.net/itinerare/Alcyone/pulls/7 Co-authored-by: Amadeus[bot] <amadeus@itinerare.net> Co-committed-by: Amadeus[bot] <amadeus@itinerare.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use Spatie Media lbrary for videos.
In extension to this pr - which allows SVG. This PR just allows Videos as well 😄
Motivation
So if anyone uses Spatie Media library - they have an option to install the
php-ffmpeg/php-ffmpegpackage, which enables support for e.g. rendering a video thumbnail alongside with seamless making a<video>-tag for playback.See docs: here
This package requires
ffmpegto be installed on the system, so instead of forcing people to publish sail, i consider the extension to be valuable enough for being preinstalled in Sail.