Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix community section layout at some breakpoint #1040

Closed
driesvints opened this issue Mar 3, 2024 · 3 comments · Fixed by #1048
Closed

Fix community section layout at some breakpoint #1040

driesvints opened this issue Mar 3, 2024 · 3 comments · Fixed by #1048

Comments

@driesvints
Copy link
Member

Not sure what the breakpoint is but at some width, the community section looks a bit weird and squished.

Screenshot 2024-03-03 at 13 12 51
@fabiorodriguesroque
Copy link
Contributor

I can work on this issue. @driesvints

Context

What is causing this issue is the class "container" on the transition from xl to lg.

  • Max width of XL is 1280px.
  • Max width of LG is 1024px.

and as the layout use "container and mx-auto" we lose some space on lg screens.

Solution

One of the solutions that I was thinking of it would be hide the avatar from medium to large screens.

for mobile & smaller screens

from md to lg

xl or bigger

Improvements

apart of that I can noticed some more minor ui things on transitions from xl to smaller screens:

  1. Navigation, icons & auth buttons looks like compressed on medium screens, Login button doesn't have space to follow the container size.
  1. Navigation has some weird x-padding and is not be aligned with the container.

Please let me know if hide the avatar could be the solution to this issue, and if I should open an issue & pr to fix this two minor things.

@driesvints
Copy link
Member Author

Hmm I think we'd still want to show the avatar. Maybe we can work with a truncate on the username and also make the font smaller on that breakpoint?

@driesvints
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants