Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a vertex along with an ROI #47

Closed
twongjirad opened this issue Jul 21, 2016 · 6 comments
Closed

Setting a vertex along with an ROI #47

twongjirad opened this issue Jul 21, 2016 · 6 comments
Assignees

Comments

@twongjirad
Copy link
Member

twongjirad commented Jul 21, 2016

For certain scanning tasks, we might want to be able to set a vertex in conjunction with the ROI. The immediate use case is for scanning Michel electrons. The ROI encapsulates the entire shower while the vertex marks the point of the decay. Together, along with Kalman filter, we'd start from vertex and follow muon in order to mask it, leaving only the electron charge. Also, vertex provides target for regression.

I've made a first attempt at 0511351

An example of what a user might label is here:

screen shot 2016-07-21 at 3 32 41 am

If can develop algorithm to follow muon, then we can avoid having users mark pixels directly.

@twongjirad twongjirad self-assigned this Jul 21, 2016
@twongjirad
Copy link
Member Author

Currently can draw vertex. Need to decide how to save that information into an ROI.

@twongjirad
Copy link
Member Author

twongjirad commented Jul 25, 2016

Looks like @drinkingkazu has written storage class for 2D vertex: a22f14b. going to merge master with tmw_roi_feature and then utilize object to store hand-scanned vertex.

@twongjirad
Copy link
Member Author

Lauren found a bug. Occurs when loading ROIs from file.

Traceback (most recent call last):
  File "/Users/twongjirad/working/larbys/LArCV/mac/pyrgb/display/rgbdisplay.py", line 524, in plotData
    self.roitool_layout.reloadROI()
  File "/Users/twongjirad/working/larbys/LArCV/mac/pyrgb/display/roilayout.py", line 358, in reloadROI
    if not self.roisg.fix_vertex_to_bb:
AttributeError: 'ROIToolLayout' object has no attribute 'roisg'

@drinkingkazu
Copy link

drinkingkazu commented Jul 26, 2016

@twongjirad a clarification on 2D stuff in 2 categories:

Simple product for pixel location info
Pixel2D ... just pixel coordinate
Pixel2DCluster ... a set of such poop

Sophisticated product for geometrical calculation (algorithm to be ported from another geometrical computation package)
Vector2D ... double precision coordinate
LineSegment2D ... two Vector2D to define a finite line segment
AABox2D ... two Vector2D to define axis-aligned box

I think anything a user will do from GUI has no better precision than a pixel point, so Pixel2D should be enough.
If we want to store a value associated with each Pixel2D we can define something else (like Hit2D maybe... as something carrying time, wire, and value).

@twongjirad
Copy link
Member Author

I finished the save feature here. Will check into tmw_roi_feature soon.

@twongjirad
Copy link
Member Author

finished: d839117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants