Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saving ROI content as a picture #52

Closed
erezcoh4 opened this issue Jul 26, 2016 · 5 comments
Closed

saving ROI content as a picture #52

erezcoh4 opened this issue Jul 26, 2016 · 5 comments
Assignees

Comments

@erezcoh4
Copy link

In order to make manual-scan easier, I thought of looping over the larcv-events and plotting 3-images with the three ROIs contents, where the ROIs are given their initial values from our list of GBDT candidates.
Does this make sense?

@drinkingkazu
Copy link

@erezcoh4 so the viewer has a capability to show ROI already. Do I understand it right that you want to show image-just-inside-ROI automatically?

If that is the case, 2 possible solutions I can think of:

  1. Make that as a viewer feature (i.e. enable auto-focus mode that shows inside ROI by default when moving one event to another)

  2. Run a cropper module to crop ROI region from an image

We want a module like 1) whether we choose that for this particular request or not imho. It is a handy module. I just cannot remember if we have such module.

@erezcoh4
Copy link
Author

I'll be glad to go with option 1 and run a cropper. I tried to look for examples on-line but couldn't manage to implement them on the display layout

@drinkingkazu
Copy link

OK so I just wanted to point out you should have this feature w/ 0) if you want it right away.
I am happy to be in charge of 1).

@drinkingkazu drinkingkazu self-assigned this Jul 28, 2016
@erezcoh4
Copy link
Author

thanks
i'd be glad to then learn how you implemented it, whenever you have time to teach me

@drinkingkazu
Copy link

OK after discussing w/ Taritree this morning making a chain work to produce cropped-ROI-image for proton sample is on my to-do list. I just pushed CropROI module that works w/ unit testing.
e41e0c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants