Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outlines in the list of projects using Lark #1407

Closed
rlouf opened this issue Apr 11, 2024 · 2 comments · Fixed by #1408
Closed

Add outlines in the list of projects using Lark #1407

rlouf opened this issue Apr 11, 2024 · 2 comments · Fixed by #1408
Labels

Comments

@rlouf
Copy link
Contributor

rlouf commented Apr 11, 2024

I am a maintainer of the Outlines library, and we use Lark to help Large Language Models generate text in the language of any formal grammars. The repository is fairly popular in the LLM world, and I was wondering if you would accept a PR that add the project to the README in the section on libraries that use Lark.

Thank you for the great work!

@rlouf rlouf added the question label Apr 11, 2024
@erezsh
Copy link
Member

erezsh commented Apr 11, 2024

Sure, I would be happy to.

Btw, it looks like you're accessing and overriding a lot of Lark's internal implementation. I wonder why that was necessary, and if perhaps there is a less invasive way of doing that?

Anyway, as long as you do, I suggest pinning to a specific lark version. I can't guarantee that internal details won't change in the future.

@rlouf
Copy link
Contributor Author

rlouf commented Apr 15, 2024

Btw, it looks like you're accessing and overriding a lot of Lark's internal implementation. I wonder why that was necessary, and if perhaps there is a less invasive way of doing that?

You would have to ask @brandonwillard.

Anyway, as long as you do, I suggest pinning to a specific lark version. I can't guarantee that internal details won't change in the future.

That's a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants