-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macros support? #5
Comments
Twig.js supports it so we should be able to support it. |
I tried playing around with some simpler implementations and noticed that it seemed to work intermittently. But the error that came up (in browser) was always the same |
Can you give #6 a try? Test in the PR seems to show it working, even with self references. Took me a while to get it going because I naffed up the macro syntax in the test twig files 🙃 |
Happy to make a release with #6 if that's easier for testing, it doesn't make things any worse |
Seems to be working, locally. Thank you! Also working in the codesandbox |
Cutting a new tag |
Tyvm, this plugin has made working with Twig and Storybook so easy! |
Does this plugin support Twig macros? I'm trying to use one in
pagination/templates/pagination-unbounded
, but I'm getting the following errorAn error occurred whilst rendering /project/home/ihiutch/workspace/stories/pagination/templates/pagination-unbounded.twig: TypeError: Cannot read properties of undefined (reading 'valueOf')
Codesandbox
**Also, excuse the other files, I found this plugin and am in the midst of migrating (If I can get macros to work!)
The text was updated successfully, but these errors were encountered: