Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidX compatible? #3

Closed
jasonlaw opened this issue May 3, 2019 · 8 comments
Closed

AndroidX compatible? #3

jasonlaw opened this issue May 3, 2019 · 8 comments
Labels
androidx enhancement New feature or request

Comments

@jasonlaw
Copy link

jasonlaw commented May 3, 2019

Hi @larryaasen ,
Is this package ready for AndroidX? If not, do you have a plan to do so?

Thanks in advance.

@larryaasen
Copy link
Owner

@jasonlaw That is a good question, and I don't know much about AndroidX and packages at this point. I need to look into this more and determine what needs to be changed to support AndroidX.

@larryaasen larryaasen added enhancement New feature or request androidx help wanted Extra attention is needed labels May 4, 2019
@jasonlaw
Copy link
Author

jasonlaw commented May 5, 2019

Hi @larryaasen ,

I am using this as reference: https://flutter.dev/docs/development/packages-and-plugins/androidx-compatibility

From your package reference, at least I see the package_info is not AndroidX compatible.
image

This is from the package_info released notes:
image

Hope this help.

@larryaasen
Copy link
Owner

@jasonlaw Thanks for pointing that out. I am updating all of the packages in the pubspec.yaml file (actually 5 of them) to pickup the versions that now support AndroidX. I should have this ready soon.

@larryaasen
Copy link
Owner

larryaasen commented May 5, 2019

I just published version 0.5.0 of this upgrader package at https://pub.dartlang.org/packages/upgrader. I updated dependent packages to AndroidX compatible versions.

Commit: 3a118ae

@jasonlaw Please let me know if this runs in your AndroidX app.

@larryaasen larryaasen removed the help wanted Extra attention is needed label May 5, 2019
@jasonlaw
Copy link
Author

jasonlaw commented May 5, 2019

Hi @larryaasen ,

Thanks for the fast action! I will definitely try this in my app. Thanks again!

@stevenspiel
Copy link

Hey, great work. I'm excited to use this plugin.

There appears to be a compatibility issue with Flutter stable, which is currently using Dart SDK 2.1.2-dev.0.0.flutter-0a7dcf17eb. I tried installing 0.5.0 today, but ran into this issue:

The current Dart SDK version is 2.1.2-dev.0.0.flutter-0a7dcf17eb.

Because upgrader >=0.5.0 depends on xml >=3.4.0 which requires SDK version >=2.2.0 <3.0.0, upgrader >=0.5.0 is forbidden.


So, because zboviq depends on upgrader ^0.5.0, version solving failed.

Which Flutter channel are you using?

@larryaasen
Copy link
Owner

@stevenspiel I published version 0.5.1 of this pack using Dart 2.2.0 and xml 3.4.0 which passed the tests on the Flutter dev branch. Hopefully, this will solve your problem.

@stevenspiel
Copy link

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
androidx enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants