Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to PR from fork not working? #6

Open
mgeier opened this issue Oct 10, 2019 · 11 comments
Open

Link to PR from fork not working? #6

mgeier opened this issue Oct 10, 2019 · 11 comments

Comments

@mgeier
Copy link

mgeier commented Oct 10, 2019

I think this might actually be due to me using wrong settings on CircleCI, but probably you can help me with it anyway?

Here's an example: spatialaudio/nbsphinx#334

The redirector bot provided this link: https://16-46379698-gh.circle-artifacts.com/0/html/index.html (which leads to a page saying "Build not found").

The correct link would be https://16-210404706-gh.circle-artifacts.com/0/html/index.html.

The reason for the confusion might be that the CircleCI build runs on the account of the fork (https://circleci.com/gh/mgeier/nbsphinx/16) instead of the main repo (which would be https://circleci.com/gh/spatialaudio/nbsphinx/). Both repos have CircleCI configured (maybe that's bad?).

Is there something wrong with my CircleCI settings?
@larsoner
Copy link
Owner

Yes it's likely a problem if CircleCI is set up both places. The redirector just looks at the status update on GitHub and appends a URL. So if your fork's build pushes a status update after (or instead of) the main repo's CircleCI build, it will point to that one:

https://github.com/larsoner/circleci-artifacts-redirector/blob/master/index.js#L13-L20

PR welcome to improve the logic if you know how, I'm not sure how to differentiate the two but there is probably a way to do so

@mgeier
Copy link
Author

mgeier commented Oct 10, 2019

Well the strange thing is that the CircleCI job seems to be running on the fork, even though the PR was created on the main repo. I would have expected it to run on the main repo.
I guess normally this doesn't happen if the fork doesn't have CircleCI setup, which is probably the more common case anyway (but I think it's very useful for contributors to run CI on their fork before making a PR).

Interestingly, the buildId (which is extracted from context.payload.target_url) seems to be correct.

Do you happen to know the full content of context.payload.target_url?
Does it maybe also contain the repo ID?
Getting it from context.payload.repository.id was wrong in my case.

@larsoner
Copy link
Owner

larsoner commented Oct 10, 2019 •
edited

Here is an example of what I assume was the problematic payload (trimmed):

{
  "id": 7849469699,
  "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
  "name": "mgeier/nbsphinx",
  "target_url": "https://circleci.com/gh/mgeier/nbsphinx/16?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link",
  "avatar_url": "https://avatars2.githubusercontent.com/oa/4808?v=4",
  "context": "ci/circleci: build_docs",
  "description": "Your tests passed on CircleCI!",
  "state": "success",
  "commit": {
    "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "node_id": "MDY6Q29tbWl0MjEwNDA0NzA2OmFkMzU5NGQ3MzcyZDdkYmUxMDE2ZmI5MzY4ZDRhMmM1MjMzZTVmZmY=",
    "commit": {
      "author": {
        "name": "Matthias Geier",
        "email": "Matthias.Geier@gmail.com",
        "date": "2019-10-08T13:24:14Z"
      },
      "committer": {
        "name": "Matthias Geier",
        "email": "Matthias.Geier@gmail.com",
        "date": "2019-10-10T09:07:14Z"
      },
      "message": "Binder: enable widgets",
      "tree": {
        "sha": "aa7ed559bf7adfe4b5502e142f3eb9172264b5c8",
        "url": "https://api.github.com/repos/mgeier/nbsphinx/git/trees/aa7ed559bf7adfe4b5502e142f3eb9172264b5c8"
      },
      "url": "https://api.github.com/repos/mgeier/nbsphinx/git/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
      "comment_count": 0,
      "verification": {
        "verified": false,
        "reason": "unsigned",
        "signature": null,
        "payload": null
      }
    },
    "url": "https://api.github.com/repos/mgeier/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "html_url": "https://github.com/mgeier/nbsphinx/commit/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "comments_url": "https://api.github.com/repos/mgeier/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff/comments",
    "author": {
      "login": "mgeier",
      "id": 705404,
      "node_id": "MDQ6VXNlcjcwNTQwNA==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "committer": {
      "login": "mgeier",
      "id": 705404,
      "node_id": "MDQ6VXNlcjcwNTQwNA==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "parents": [
      {
        "sha": "0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f",
        "url": "https://api.github.com/repos/mgeier/nbsphinx/commits/0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f",
        "html_url": "https://github.com/mgeier/nbsphinx/commit/0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f"
      }
    ]
  },
  "branches": [
    {
      "name": "travis-python-2.7",
      "commit": {
        "sha": "84ab0e80abbfa0e65d31802014bae948675e29ae",
        "url": "https://api.github.com/repos/mgeier/nbsphinx/commits/84ab0e80abbfa0e65d31802014bae948675e29ae"
      },
      "protected": false
    },
    {
      "name": "widget-docs",
      "commit": {
        "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
        "url": "https://api.github.com/repos/mgeier/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff"
      },
      "protected": false
    }
  ],
  "created_at": "2019-10-10T09:10:49+00:00",
  "updated_at": "2019-10-10T09:10:49+00:00",
  "repository": {
    "id": 210404706,
    "node_id": "MDEwOlJlcG9zaXRvcnkyMTA0MDQ3MDY=",
    "name": "nbsphinx",
    "full_name": "mgeier/nbsphinx",
    "private": false,
    "owner": {
      "login": "mgeier",
      "id": 705404,
      "node_id": "MDQ6VXNlcjcwNTQwNA==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "html_url": "https://github.com/mgeier/nbsphinx",
    "description": ":ledger: Sphinx source parser for *.ipynb files",
    "fork": true,
    "url": "https://api.github.com/repos/mgeier/nbsphinx",
    "forks_url": "https://api.github.com/repos/mgeier/nbsphinx/forks",
    "keys_url": "https://api.github.com/repos/mgeier/nbsphinx/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/mgeier/nbsphinx/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/mgeier/nbsphinx/teams",
    "hooks_url": "https://api.github.com/repos/mgeier/nbsphinx/hooks",
    "issue_events_url": "https://api.github.com/repos/mgeier/nbsphinx/issues/events{/number}",
    "events_url": "https://api.github.com/repos/mgeier/nbsphinx/events",
    "assignees_url": "https://api.github.com/repos/mgeier/nbsphinx/assignees{/user}",
    "branches_url": "https://api.github.com/repos/mgeier/nbsphinx/branches{/branch}",
    "tags_url": "https://api.github.com/repos/mgeier/nbsphinx/tags",
    "blobs_url": "https://api.github.com/repos/mgeier/nbsphinx/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/mgeier/nbsphinx/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/mgeier/nbsphinx/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/mgeier/nbsphinx/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/mgeier/nbsphinx/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/mgeier/nbsphinx/languages",
    "stargazers_url": "https://api.github.com/repos/mgeier/nbsphinx/stargazers",
    "contributors_url": "https://api.github.com/repos/mgeier/nbsphinx/contributors",
    "subscribers_url": "https://api.github.com/repos/mgeier/nbsphinx/subscribers",
    "subscription_url": "https://api.github.com/repos/mgeier/nbsphinx/subscription",
    "commits_url": "https://api.github.com/repos/mgeier/nbsphinx/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/mgeier/nbsphinx/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/mgeier/nbsphinx/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/mgeier/nbsphinx/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/mgeier/nbsphinx/contents/{+path}",
    "compare_url": "https://api.github.com/repos/mgeier/nbsphinx/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/mgeier/nbsphinx/merges",
    "archive_url": "https://api.github.com/repos/mgeier/nbsphinx/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/mgeier/nbsphinx/downloads",
    "issues_url": "https://api.github.com/repos/mgeier/nbsphinx/issues{/number}",
    "pulls_url": "https://api.github.com/repos/mgeier/nbsphinx/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/mgeier/nbsphinx/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/mgeier/nbsphinx/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/mgeier/nbsphinx/labels{/name}",
    "releases_url": "https://api.github.com/repos/mgeier/nbsphinx/releases{/id}",
    "deployments_url": "https://api.github.com/repos/mgeier/nbsphinx/deployments",
    "created_at": "2019-09-23T16:39:40Z",
    "updated_at": "2019-09-23T16:39:41Z",
    "pushed_at": "2019-10-10T09:08:10Z",
    "git_url": "git://github.com/mgeier/nbsphinx.git",
    "ssh_url": "git@github.com:mgeier/nbsphinx.git",
    "clone_url": "https://github.com/mgeier/nbsphinx.git",
    "svn_url": "https://github.com/mgeier/nbsphinx",
    "homepage": "https://nbsphinx.readthedocs.io/",
    "size": 660,
    "stargazers_count": 0,
    "watchers_count": 0,
    "language": null,
    "has_issues": false,
    "has_projects": true,
    "has_downloads": true,
    "has_wiki": true,
    "has_pages": false,
    "forks_count": 0,
    "mirror_url": null,
    "archived": false,
    "disabled": false,
    "open_issues_count": 0,
    "license": {
      "key": "mit",
      "name": "MIT License",
      "spdx_id": "MIT",
      "url": "https://api.github.com/licenses/mit",
      "node_id": "MDc6TGljZW5zZTEz"
    },
    "forks": 0,
    "open_issues": 0,
    "watchers": 0,
    "default_branch": "master"
  },
  "sender": {
    "login": "mgeier",
    "id": 705404,
    "node_id": "MDQ6VXNlcjcwNTQwNA==",
    "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/mgeier",
    "html_url": "https://github.com/mgeier",
    "followers_url": "https://api.github.com/users/mgeier/followers",
    "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
    "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
    "organizations_url": "https://api.github.com/users/mgeier/orgs",
    "repos_url": "https://api.github.com/users/mgeier/repos",
    "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
    "received_events_url": "https://api.github.com/users/mgeier/received_events",
    "type": "User",
    "site_admin": false
  },
...

From which my app produced this payload (presumably the bad one) And this is a payload produced by the app which is correct (in response to a different payload):

{
  "id": 7849469882,
  "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
  "name": "mgeier/nbsphinx",
  "target_url": "https://16-210404706-gh.circle-artifacts.com/0/html/index.html\n",
  "avatar_url": "https://avatars0.githubusercontent.com/in/38949?v=4",
  "context": "ci/circleci: build_docs artifact",
  "description": "Link to 0/html/index.html\n",
  "state": "success",
  "commit": {
    "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "node_id": "MDY6Q29tbWl0MjEwNDA0NzA2OmFkMzU5NGQ3MzcyZDdkYmUxMDE2ZmI5MzY4ZDRhMmM1MjMzZTVmZmY=",
    "commit": {
      "author": {
        "name": "Matthias Geier",
        "email": "Matthias.Geier@gmail.com",
        "date": "2019-10-08T13:24:14Z"
      },
      "committer": {
        "name": "Matthias Geier",
        "email": "Matthias.Geier@gmail.com",
        "date": "2019-10-10T09:07:14Z"
      },
      "message": "Binder: enable widgets",
      "tree": {
        "sha": "aa7ed559bf7adfe4b5502e142f3eb9172264b5c8",
        "url": "https://api.github.com/repos/mgeier/nbsphinx/git/trees/aa7ed559bf7adfe4b5502e142f3eb9172264b5c8"
      },
      "url": "https://api.github.com/repos/mgeier/nbsphinx/git/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
      "comment_count": 0,
      "verification": {
        "verified": false,
        "reason": "unsigned",
        "signature": null,
        "payload": null
      }
    },
    "url": "https://api.github.com/repos/mgeier/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "html_url": "https://github.com/mgeier/nbsphinx/commit/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "comments_url": "https://api.github.com/repos/mgeier/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff/comments",
    "author": {
      "login": "mgeier",
      "id": <redacted>,
      "node_id": <redacted>,
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "committer": {
      "login": "mgeier",
      "id": <redacted>,
      "node_id": <redacted>,
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "parents": [
      {
        "sha": "0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f",
        "url": "https://api.github.com/repos/mgeier/nbsphinx/commits/0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f",
        "html_url": "https://github.com/mgeier/nbsphinx/commit/0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f"
      }
    ]
  },
  "branches": [
    {
      "name": "travis-python-2.7",
      "commit": {
        "sha": "84ab0e80abbfa0e65d31802014bae948675e29ae",
        "url": "https://api.github.com/repos/mgeier/nbsphinx/commits/84ab0e80abbfa0e65d31802014bae948675e29ae"
      },
      "protected": false
    },
    {
      "name": "widget-docs",
      "commit": {
        "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
        "url": "https://api.github.com/repos/mgeier/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff"
      },
      "protected": false
    }
  ],
  "created_at": "2019-10-10T09:10:50+00:00",
  "updated_at": "2019-10-10T09:10:50+00:00",
  "repository": {
    "id": <redacted>,
    "node_id": <redacted>,
    "name": "nbsphinx",
    "full_name": "mgeier/nbsphinx",
    "private": false,
    "owner": {
      "login": "mgeier",
      "id": <redacted>,
      "node_id": <redacted>,
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "html_url": "https://github.com/mgeier/nbsphinx",
    "description": ":ledger: Sphinx source parser for *.ipynb files",
    "fork": true,
    "url": "https://api.github.com/repos/mgeier/nbsphinx",
    "forks_url": "https://api.github.com/repos/mgeier/nbsphinx/forks",
    "keys_url": "https://api.github.com/repos/mgeier/nbsphinx/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/mgeier/nbsphinx/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/mgeier/nbsphinx/teams",
    "hooks_url": "https://api.github.com/repos/mgeier/nbsphinx/hooks",
    "issue_events_url": "https://api.github.com/repos/mgeier/nbsphinx/issues/events{/number}",
    "events_url": "https://api.github.com/repos/mgeier/nbsphinx/events",
    "assignees_url": "https://api.github.com/repos/mgeier/nbsphinx/assignees{/user}",
    "branches_url": "https://api.github.com/repos/mgeier/nbsphinx/branches{/branch}",
    "tags_url": "https://api.github.com/repos/mgeier/nbsphinx/tags",
    "blobs_url": "https://api.github.com/repos/mgeier/nbsphinx/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/mgeier/nbsphinx/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/mgeier/nbsphinx/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/mgeier/nbsphinx/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/mgeier/nbsphinx/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/mgeier/nbsphinx/languages",
    "stargazers_url": "https://api.github.com/repos/mgeier/nbsphinx/stargazers",
    "contributors_url": "https://api.github.com/repos/mgeier/nbsphinx/contributors",
    "subscribers_url": "https://api.github.com/repos/mgeier/nbsphinx/subscribers",
    "subscription_url": "https://api.github.com/repos/mgeier/nbsphinx/subscription",
    "commits_url": "https://api.github.com/repos/mgeier/nbsphinx/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/mgeier/nbsphinx/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/mgeier/nbsphinx/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/mgeier/nbsphinx/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/mgeier/nbsphinx/contents/{+path}",
    "compare_url": "https://api.github.com/repos/mgeier/nbsphinx/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/mgeier/nbsphinx/merges",
    "archive_url": "https://api.github.com/repos/mgeier/nbsphinx/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/mgeier/nbsphinx/downloads",
    "issues_url": "https://api.github.com/repos/mgeier/nbsphinx/issues{/number}",
    "pulls_url": "https://api.github.com/repos/mgeier/nbsphinx/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/mgeier/nbsphinx/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/mgeier/nbsphinx/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/mgeier/nbsphinx/labels{/name}",
    "releases_url": "https://api.github.com/repos/mgeier/nbsphinx/releases{/id}",
    "deployments_url": "https://api.github.com/repos/mgeier/nbsphinx/deployments",
    "created_at": "2019-09-23T16:39:40Z",
    "updated_at": "2019-09-23T16:39:41Z",
    "pushed_at": "2019-10-10T09:08:10Z",
    "git_url": "git://github.com/mgeier/nbsphinx.git",
    "ssh_url": "git@github.com:mgeier/nbsphinx.git",
    "clone_url": "https://github.com/mgeier/nbsphinx.git",
    "svn_url": "https://github.com/mgeier/nbsphinx",
    "homepage": "https://nbsphinx.readthedocs.io/",
    "size": 660,
    "stargazers_count": 0,
    "watchers_count": 0,
    "language": null,
    "has_issues": false,
    "has_projects": true,
    "has_downloads": true,
    "has_wiki": true,
    "has_pages": false,
    "forks_count": 0,
    "mirror_url": null,
    "archived": false,
    "disabled": false,
    "open_issues_count": 0,
    "license": {
      "key": "mit",
      "name": "MIT License",
      "spdx_id": "MIT",
      "url": "https://api.github.com/licenses/mit",
      "node_id": "MDc6TGljZW5zZTEz"
    },
    "forks": 0,
    "open_issues": 0,
    "watchers": 0,
    "default_branch": "master"
  },
  "sender": {
    "login": "circleci-artifacts-redirector[bot]",
    "id": 54281198,
    "node_id": "MDM6Qm90NTQyODExOTg=",
    "avatar_url": "https://avatars0.githubusercontent.com/in/38949?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D",
    "html_url": "https://github.com/apps/circleci-artifacts-redirector",
    "followers_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/followers",
    "following_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/following{/other_user}",
    "gists_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/subscriptions",
    "organizations_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/orgs",
    "repos_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/repos",
    "events_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/events{/privacy}",
    "received_events_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/received_events",
    "type": "Bot",
    "site_admin": false
  },
...

@mgeier
Copy link
Author

mgeier commented Oct 10, 2019

That's strange, because the generated URL is the correct one (except probably for the trailing \n):

"target_url": "https://16-210404706-gh.circle-artifacts.com/0/html/index.html\n"

The (faulty) one that was shown on the Github PR page was https://16-46379698-gh.circle-artifacts.com/0/html/index.html, with repo ID 46379698, which doesn't appear anywhere in your data ...

@larsoner
Copy link
Owner

Argh yes I pasted the wrong payload. That was the correct one (a response to a CircleCI update that came in less than a second earlier). There are hundreds of them and finding the "right" one is difficult...

In case I need these again: this all happened around 2019-10-10 05:10:49, give or take a second. This was the app's response to the "bad" delivery above:

{
  "id": 7849469926,
  "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
  "name": "spatialaudio/nbsphinx",
  "target_url": "https://16-46379698-gh.circle-artifacts.com/0/html/index.html\n",
  "avatar_url": "https://avatars0.githubusercontent.com/in/38949?v=4",
  "context": "ci/circleci: build_docs artifact",
  "description": "Link to 0/html/index.html\n",
  "state": "success",
  "commit": {
    "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "node_id": "MDY6Q29tbWl0NDYzNzk2OTg6YWQzNTk0ZDczNzJkN2RiZTEwMTZmYjkzNjhkNGEyYzUyMzNlNWZmZg==",
    "commit": {
      "author": {
        "name": "Matthias Geier",
        "email": "Matthias.Geier@gmail.com",
        "date": "2019-10-08T13:24:14Z"
      },
      "committer": {
        "name": "Matthias Geier",
        "email": "Matthias.Geier@gmail.com",
        "date": "2019-10-10T09:07:14Z"
      },
      "message": "Binder: enable widgets",
      "tree": {
        "sha": "aa7ed559bf7adfe4b5502e142f3eb9172264b5c8",
        "url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/trees/aa7ed559bf7adfe4b5502e142f3eb9172264b5c8"
      },
      "url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
      "comment_count": 0,
      "verification": {
        "verified": false,
        "reason": "unsigned",
        "signature": null,
        "payload": null
      }
    },
    "url": "https://api.github.com/repos/spatialaudio/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "html_url": "https://github.com/spatialaudio/nbsphinx/commit/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "comments_url": "https://api.github.com/repos/spatialaudio/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff/comments",
    "author": {
      "login": "mgeier",
      "id": <redacted>,
      "node_id": <redacted>,
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "committer": {
      "login": "mgeier",
      "id": <redacted>,
      "node_id": <redacted>,
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "parents": [
      {
        "sha": "0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f",
        "url": "https://api.github.com/repos/spatialaudio/nbsphinx/commits/0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f",
        "html_url": "https://github.com/spatialaudio/nbsphinx/commit/0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f"
      }
    ]
  },
  "branches": [

  ],
  "created_at": "2019-10-10T09:10:50+00:00",
  "updated_at": "2019-10-10T09:10:50+00:00",
  "repository": {
    "id": 46379698,
    "node_id": "MDEwOlJlcG9zaXRvcnk0NjM3OTY5OA==",
    "name": "nbsphinx",
    "full_name": "spatialaudio/nbsphinx",
    "private": false,
    "owner": {
      "login": "spatialaudio",
      "id": 7491513,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjc0OTE1MTM=",
      "avatar_url": "https://avatars1.githubusercontent.com/u/7491513?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/spatialaudio",
      "html_url": "https://github.com/spatialaudio",
      "followers_url": "https://api.github.com/users/spatialaudio/followers",
      "following_url": "https://api.github.com/users/spatialaudio/following{/other_user}",
      "gists_url": "https://api.github.com/users/spatialaudio/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/spatialaudio/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/spatialaudio/subscriptions",
      "organizations_url": "https://api.github.com/users/spatialaudio/orgs",
      "repos_url": "https://api.github.com/users/spatialaudio/repos",
      "events_url": "https://api.github.com/users/spatialaudio/events{/privacy}",
      "received_events_url": "https://api.github.com/users/spatialaudio/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/spatialaudio/nbsphinx",
    "description": ":ledger: Sphinx source parser for *.ipynb files",
    "fork": false,
    "url": "https://api.github.com/repos/spatialaudio/nbsphinx",
    "forks_url": "https://api.github.com/repos/spatialaudio/nbsphinx/forks",
    "keys_url": "https://api.github.com/repos/spatialaudio/nbsphinx/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/spatialaudio/nbsphinx/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/spatialaudio/nbsphinx/teams",
    "hooks_url": "https://api.github.com/repos/spatialaudio/nbsphinx/hooks",
    "issue_events_url": "https://api.github.com/repos/spatialaudio/nbsphinx/issues/events{/number}",
    "events_url": "https://api.github.com/repos/spatialaudio/nbsphinx/events",
    "assignees_url": "https://api.github.com/repos/spatialaudio/nbsphinx/assignees{/user}",
    "branches_url": "https://api.github.com/repos/spatialaudio/nbsphinx/branches{/branch}",
    "tags_url": "https://api.github.com/repos/spatialaudio/nbsphinx/tags",
    "blobs_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/spatialaudio/nbsphinx/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/spatialaudio/nbsphinx/languages",
    "stargazers_url": "https://api.github.com/repos/spatialaudio/nbsphinx/stargazers",
    "contributors_url": "https://api.github.com/repos/spatialaudio/nbsphinx/contributors",
    "subscribers_url": "https://api.github.com/repos/spatialaudio/nbsphinx/subscribers",
    "subscription_url": "https://api.github.com/repos/spatialaudio/nbsphinx/subscription",
    "commits_url": "https://api.github.com/repos/spatialaudio/nbsphinx/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/spatialaudio/nbsphinx/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/spatialaudio/nbsphinx/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/spatialaudio/nbsphinx/contents/{+path}",
    "compare_url": "https://api.github.com/repos/spatialaudio/nbsphinx/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/spatialaudio/nbsphinx/merges",
    "archive_url": "https://api.github.com/repos/spatialaudio/nbsphinx/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/spatialaudio/nbsphinx/downloads",
    "issues_url": "https://api.github.com/repos/spatialaudio/nbsphinx/issues{/number}",
    "pulls_url": "https://api.github.com/repos/spatialaudio/nbsphinx/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/spatialaudio/nbsphinx/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/spatialaudio/nbsphinx/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/spatialaudio/nbsphinx/labels{/name}",
    "releases_url": "https://api.github.com/repos/spatialaudio/nbsphinx/releases{/id}",
    "deployments_url": "https://api.github.com/repos/spatialaudio/nbsphinx/deployments",
    "created_at": "2015-11-17T22:32:56Z",
    "updated_at": "2019-10-10T09:04:18Z",
    "pushed_at": "2019-10-10T09:08:11Z",
    "git_url": "git://github.com/spatialaudio/nbsphinx.git",
    "ssh_url": "git@github.com:spatialaudio/nbsphinx.git",
    "clone_url": "https://github.com/spatialaudio/nbsphinx.git",
    "svn_url": "https://github.com/spatialaudio/nbsphinx",
    "homepage": "https://nbsphinx.readthedocs.io/",
    "size": 850,
    "stargazers_count": 202,
    "watchers_count": 202,
    "language": "Python",
    "has_issues": true,
    "has_projects": false,
    "has_downloads": true,
    "has_wiki": true,
    "has_pages": false,
    "forks_count": 62,
    "mirror_url": null,
    "archived": false,
    "disabled": false,
    "open_issues_count": 52,
    "license": {
      "key": "mit",
      "name": "MIT License",
      "spdx_id": "MIT",
      "url": "https://api.github.com/licenses/mit",
      "node_id": "MDc6TGljZW5zZTEz"
    },
    "forks": 62,
    "open_issues": 52,
    "watchers": 202,
    "default_branch": "master"
  },
  "organization": {
    "login": "spatialaudio",
    "id": 7491513,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjc0OTE1MTM=",
    "url": "https://api.github.com/orgs/spatialaudio",
    "repos_url": "https://api.github.com/orgs/spatialaudio/repos",
    "events_url": "https://api.github.com/orgs/spatialaudio/events",
    "hooks_url": "https://api.github.com/orgs/spatialaudio/hooks",
    "issues_url": "https://api.github.com/orgs/spatialaudio/issues",
    "members_url": "https://api.github.com/orgs/spatialaudio/members{/member}",
    "public_members_url": "https://api.github.com/orgs/spatialaudio/public_members{/member}",
    "avatar_url": "https://avatars1.githubusercontent.com/u/7491513?v=4",
    "description": ""
  },
  "sender": {
    "login": "circleci-artifacts-redirector[bot]",
    "id": 54281198,
    "node_id": "MDM6Qm90NTQyODExOTg=",
    "avatar_url": "https://avatars0.githubusercontent.com/in/38949?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D",
    "html_url": "https://github.com/apps/circleci-artifacts-redirector",
    "followers_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/followers",
    "following_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/following{/other_user}",
    "gists_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/subscriptions",
    "organizations_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/orgs",
    "repos_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/repos",
    "events_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/events{/privacy}",
    "received_events_url": "https://api.github.com/users/circleci-artifacts-redirector%5Bbot%5D/received_events",
    "type": "Bot",
    "site_admin": false
  },
...

@larsoner
Copy link
Owner

... and for completeness, here is the other payload that triggered the app to update (at this point not sure which of the two payloads was correct/incorrect):

{
  "id": 7849469728,
  "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
  "name": "spatialaudio/nbsphinx",
  "target_url": "https://circleci.com/gh/mgeier/nbsphinx/16?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link",
  "avatar_url": "https://avatars2.githubusercontent.com/oa/4808?v=4",
  "context": "ci/circleci: build_docs",
  "description": "Your tests passed on CircleCI!",
  "state": "success",
  "commit": {
    "sha": "ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "node_id": "MDY6Q29tbWl0NDYzNzk2OTg6YWQzNTk0ZDczNzJkN2RiZTEwMTZmYjkzNjhkNGEyYzUyMzNlNWZmZg==",
    "commit": {
      "author": {
        "name": "Matthias Geier",
        "email": "Matthias.Geier@gmail.com",
        "date": "2019-10-08T13:24:14Z"
      },
      "committer": {
        "name": "Matthias Geier",
        "email": "Matthias.Geier@gmail.com",
        "date": "2019-10-10T09:07:14Z"
      },
      "message": "Binder: enable widgets",
      "tree": {
        "sha": "aa7ed559bf7adfe4b5502e142f3eb9172264b5c8",
        "url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/trees/aa7ed559bf7adfe4b5502e142f3eb9172264b5c8"
      },
      "url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
      "comment_count": 0,
      "verification": {
        "verified": false,
        "reason": "unsigned",
        "signature": null,
        "payload": null
      }
    },
    "url": "https://api.github.com/repos/spatialaudio/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "html_url": "https://github.com/spatialaudio/nbsphinx/commit/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff",
    "comments_url": "https://api.github.com/repos/spatialaudio/nbsphinx/commits/ad3594d7372d7dbe1016fb9368d4a2c5233e5fff/comments",
    "author": {
      "login": "mgeier",
      "id": <redacted>,
      "node_id": <redacted>,
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "committer": {
      "login": "mgeier",
      "id": <redacted>,
      "node_id": <redacted>,
      "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mgeier",
      "html_url": "https://github.com/mgeier",
      "followers_url": "https://api.github.com/users/mgeier/followers",
      "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
      "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
      "organizations_url": "https://api.github.com/users/mgeier/orgs",
      "repos_url": "https://api.github.com/users/mgeier/repos",
      "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mgeier/received_events",
      "type": "User",
      "site_admin": false
    },
    "parents": [
      {
        "sha": "0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f",
        "url": "https://api.github.com/repos/spatialaudio/nbsphinx/commits/0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f",
        "html_url": "https://github.com/spatialaudio/nbsphinx/commit/0af9c8b7ba1d350bb93ad6ed42e2a54eedbaa11f"
      }
    ]
  },
  "branches": [

  ],
  "created_at": "2019-10-10T09:10:49+00:00",
  "updated_at": "2019-10-10T09:10:49+00:00",
  "repository": {
    "id": 46379698,
    "node_id": "MDEwOlJlcG9zaXRvcnk0NjM3OTY5OA==",
    "name": "nbsphinx",
    "full_name": "spatialaudio/nbsphinx",
    "private": false,
    "owner": {
      "login": "spatialaudio",
      "id": 7491513,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjc0OTE1MTM=",
      "avatar_url": "https://avatars1.githubusercontent.com/u/7491513?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/spatialaudio",
      "html_url": "https://github.com/spatialaudio",
      "followers_url": "https://api.github.com/users/spatialaudio/followers",
      "following_url": "https://api.github.com/users/spatialaudio/following{/other_user}",
      "gists_url": "https://api.github.com/users/spatialaudio/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/spatialaudio/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/spatialaudio/subscriptions",
      "organizations_url": "https://api.github.com/users/spatialaudio/orgs",
      "repos_url": "https://api.github.com/users/spatialaudio/repos",
      "events_url": "https://api.github.com/users/spatialaudio/events{/privacy}",
      "received_events_url": "https://api.github.com/users/spatialaudio/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/spatialaudio/nbsphinx",
    "description": ":ledger: Sphinx source parser for *.ipynb files",
    "fork": false,
    "url": "https://api.github.com/repos/spatialaudio/nbsphinx",
    "forks_url": "https://api.github.com/repos/spatialaudio/nbsphinx/forks",
    "keys_url": "https://api.github.com/repos/spatialaudio/nbsphinx/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/spatialaudio/nbsphinx/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/spatialaudio/nbsphinx/teams",
    "hooks_url": "https://api.github.com/repos/spatialaudio/nbsphinx/hooks",
    "issue_events_url": "https://api.github.com/repos/spatialaudio/nbsphinx/issues/events{/number}",
    "events_url": "https://api.github.com/repos/spatialaudio/nbsphinx/events",
    "assignees_url": "https://api.github.com/repos/spatialaudio/nbsphinx/assignees{/user}",
    "branches_url": "https://api.github.com/repos/spatialaudio/nbsphinx/branches{/branch}",
    "tags_url": "https://api.github.com/repos/spatialaudio/nbsphinx/tags",
    "blobs_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/spatialaudio/nbsphinx/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/spatialaudio/nbsphinx/languages",
    "stargazers_url": "https://api.github.com/repos/spatialaudio/nbsphinx/stargazers",
    "contributors_url": "https://api.github.com/repos/spatialaudio/nbsphinx/contributors",
    "subscribers_url": "https://api.github.com/repos/spatialaudio/nbsphinx/subscribers",
    "subscription_url": "https://api.github.com/repos/spatialaudio/nbsphinx/subscription",
    "commits_url": "https://api.github.com/repos/spatialaudio/nbsphinx/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/spatialaudio/nbsphinx/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/spatialaudio/nbsphinx/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/spatialaudio/nbsphinx/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/spatialaudio/nbsphinx/contents/{+path}",
    "compare_url": "https://api.github.com/repos/spatialaudio/nbsphinx/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/spatialaudio/nbsphinx/merges",
    "archive_url": "https://api.github.com/repos/spatialaudio/nbsphinx/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/spatialaudio/nbsphinx/downloads",
    "issues_url": "https://api.github.com/repos/spatialaudio/nbsphinx/issues{/number}",
    "pulls_url": "https://api.github.com/repos/spatialaudio/nbsphinx/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/spatialaudio/nbsphinx/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/spatialaudio/nbsphinx/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/spatialaudio/nbsphinx/labels{/name}",
    "releases_url": "https://api.github.com/repos/spatialaudio/nbsphinx/releases{/id}",
    "deployments_url": "https://api.github.com/repos/spatialaudio/nbsphinx/deployments",
    "created_at": "2015-11-17T22:32:56Z",
    "updated_at": "2019-10-10T09:04:18Z",
    "pushed_at": "2019-10-10T09:08:11Z",
    "git_url": "git://github.com/spatialaudio/nbsphinx.git",
    "ssh_url": "git@github.com:spatialaudio/nbsphinx.git",
    "clone_url": "https://github.com/spatialaudio/nbsphinx.git",
    "svn_url": "https://github.com/spatialaudio/nbsphinx",
    "homepage": "https://nbsphinx.readthedocs.io/",
    "size": 850,
    "stargazers_count": 202,
    "watchers_count": 202,
    "language": "Python",
    "has_issues": true,
    "has_projects": false,
    "has_downloads": true,
    "has_wiki": true,
    "has_pages": false,
    "forks_count": 62,
    "mirror_url": null,
    "archived": false,
    "disabled": false,
    "open_issues_count": 52,
    "license": {
      "key": "mit",
      "name": "MIT License",
      "spdx_id": "MIT",
      "url": "https://api.github.com/licenses/mit",
      "node_id": "MDc6TGljZW5zZTEz"
    },
    "forks": 62,
    "open_issues": 52,
    "watchers": 202,
    "default_branch": "master"
  },
  "organization": {
    "login": "spatialaudio",
    "id": 7491513,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjc0OTE1MTM=",
    "url": "https://api.github.com/orgs/spatialaudio",
    "repos_url": "https://api.github.com/orgs/spatialaudio/repos",
    "events_url": "https://api.github.com/orgs/spatialaudio/events",
    "hooks_url": "https://api.github.com/orgs/spatialaudio/hooks",
    "issues_url": "https://api.github.com/orgs/spatialaudio/issues",
    "members_url": "https://api.github.com/orgs/spatialaudio/members{/member}",
    "public_members_url": "https://api.github.com/orgs/spatialaudio/public_members{/member}",
    "avatar_url": "https://avatars1.githubusercontent.com/u/7491513?v=4",
    "description": ""
  },
  "sender": {
    "login": "mgeier",
    "id": 705404,
    "node_id": "MDQ6VXNlcjcwNTQwNA==",
    "avatar_url": "https://avatars1.githubusercontent.com/u/705404?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/mgeier",
    "html_url": "https://github.com/mgeier",
    "followers_url": "https://api.github.com/users/mgeier/followers",
    "following_url": "https://api.github.com/users/mgeier/following{/other_user}",
    "gists_url": "https://api.github.com/users/mgeier/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/mgeier/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/mgeier/subscriptions",
    "organizations_url": "https://api.github.com/users/mgeier/orgs",
    "repos_url": "https://api.github.com/users/mgeier/repos",
    "events_url": "https://api.github.com/users/mgeier/events{/privacy}",
    "received_events_url": "https://api.github.com/users/mgeier/received_events",
    "type": "User",
    "site_admin": false
  },
...

@mgeier
Copy link
Author

mgeier commented Oct 10, 2019

Thanks a lot for digging up those logs.

Do I understand this correctly: At one point the right information was sent and a short time later (or earlier?) the wrong information was sent?

Would it help just to filter out the wrong one? Would that be possible?

I think the last one is the wrong request (#6 (comment)).

It has:

  "name": "spatialaudio/nbsphinx",
  "target_url": "https://circleci.com/gh/mgeier/nbsphinx/16?...",

... where the "name" doesn't match the "target_url".

The correct request would be the very first one:

  "name": "mgeier/nbsphinx",
  "target_url": "https://circleci.com/gh/mgeier/nbsphinx/16?...",

Here "name" is a substring of "target_url".

I of course don't know if that's generally the case ... but if it is, this should be reasonably easy to detect, right?

@larsoner
Copy link
Owner

Here "name" is a substring of "target_url".

I of course don't know if that's generally the case ... but if it is, this should be reasonably easy to detect, right?

Yeah that seems like it should work

@mgeier
Copy link
Author

mgeier commented Oct 12, 2019

Would you like to try fixing this?

I don't know how to test this and I'm quite bad at JavaScript, so I can't really make a PR for this.

@mgeier
Copy link
Author

mgeier commented Oct 12, 2019

There may be some deeper issue ... I've just created another PR and now CircleCI isn't even showing anything: spatialaudio/nbsphinx#338.

I really don't know if it is usual at all to have CircleCI activated on both the fork and the main repo, but I think it would be a really nice workflow for contributors.
Probably the problem is that I control both the fork and the main repo?

@larsoner
Copy link
Owner

I've had other issues with CircleCI when it's enabled on a fork, too.

I can look into improving this at some point but it take me a couple of weeks for me to get to it. I'm also not a JavaScript expert so it takes a bit of thinking and testing for me to get things working.

@larsoner larsoner mentioned this issue Mar 13, 2020
Open
@tsalo tsalo mentioned this issue Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgeier @larsoner