Change build shield from Travis to CircleCI

[eurunuela]

Closes #296

Proposed Changes

• Change link to Travis CI for the link to CircleCI to display correct build shield.

[codecov]

Codecov Report

Merging #297 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files           9        9           
  Lines         842      842           
=======================================
  Hits          782      782           
  Misses         60       60           

[tsalo]

You'll want to do docs/index.rst too.

[eurunuela]

You'll want to do docs/index.rst too.

What do you mean? We already have a badge for the docs.

[tsalo]

The badge in docs/index.rst still points to Travis.

Apologies for the blame view, but permalinks in RST and MD files don't work...

https://github.com/physiopy/phys2bids/blame/ff2e0e36cf6c3a2170550defbf2570114938513a/docs/index.rst#L13-L15

[eurunuela]

Oh right. I thought you were talking about the README. My bad. Will push a commit now.

[eurunuela]

Okay, I think that should make it @tsalo . Thank you!

[tsalo]

@eurunuela the build docs artifact is pointing to the wrong build. Based on larsoner/circleci-artifacts-redirector#6, I think the solution may be to enable Only build pull requests.

CircleCI phys2bids page --> Project Settings --> Advanced Settings --> turn on Only build pull requests

Would you be willing to give that a try?

[eurunuela]

@eurunuela the build docs artifact is pointing to the wrong build. Based on larsoner/circleci-artifacts-redirector#6, I think the solution may be to enable Only build pull requests.

CircleCI phys2bids page --> Project Settings --> Advanced Settings --> turn on Only build pull requests

Would you be willing to give that a try?

Done. Please let me know if there's anything else we have to change.

[eurunuela]

Just swapped the Gitter and CircleCI badges on the docs. It makes more sense to me that all the ones related to builds are next to each other.

I don't have a strong opinion on this, so let me know if you think it's not a good idea.

[tsalo]

It turns out I have permissions on the CircleCI settings for this project, so I checked them. After you enabled "Only build pull requests", I noticed that the CircleCI status checks didn't show up here on your newest commit. I went into the settings and enabled "Build forked pull requests", which should hopefully fix that. A bunch of pipelines started running, and I'm hoping that, once they're done, everything should be good here. All of the settings match my own on other projects I contribute to, so hopefully it'll be fine. I just want to wait until it all finishes before approving this.

[tsalo]

The backlog finished. Would you mind pushing one small commit to hopefully trigger things a final time?

[eurunuela]

Thanks @tsalo . Hopefully this last commit will make it work.

[tsalo]

LGTM.

[eurunuela]

It turns out I have permissions on the CircleCI settings for this project, so I checked them. After you enabled "Only build pull requests", I noticed that the CircleCI status checks didn't show up here on your newest commit. I went into the settings and enabled "Build forked pull requests", which should hopefully fix that. A bunch of pipelines started running, and I'm hoping that, once they're done, everything should be good here. All of the settings match my own on other projects I contribute to, so hopefully it'll be fine. I just want to wait until it all finishes before approving this.

It turns out I had to do that on my own CircleCI profile too, otherwise the checks only appear when merging with master.