-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if LDPL compiles statically for Windows #56
Comments
Should be fixed now yes, sorry! bb46cdf Do you want to disable static builds on Android too? If so we probably make this change now, and not require using the diff --git a/src/ldpl.h b/src/ldpl.h
index 71fafd6..fc09c57 100644
--- a/src/ldpl.h
+++ b/src/ldpl.h
@@ -12,7 +12,7 @@
using namespace std;
-#if !defined(__APPLE__)
+#if !defined(__APPLE__) && !defined(__ANDROID__)
#define STATIC_BUILDS 1
#endif
|
Ah, that could work, yes! Let's do that please! 😄 |
Hey, you uploaded a macOS binary! Awesome! Thank you very much! |
Okay doing that in #58
Np! I will do that whenever I see a new release, if I am able to. |
Great! Thank you very much! |
@dvkt I think that on this commit, Windows hability to compile static binaries was broken. Since you added the
__linux__
check, do you by any chance know what the Windows equivalent would be?Thank you!
The text was updated successfully, but these errors were encountered: