Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if LDPL compiles statically for Windows #56

Closed
Lartu opened this issue Apr 21, 2019 · 5 comments
Closed

Check if LDPL compiles statically for Windows #56

Lartu opened this issue Apr 21, 2019 · 5 comments

Comments

@Lartu
Copy link
Owner

Lartu commented Apr 21, 2019

@dvkt I think that on this commit, Windows hability to compile static binaries was broken. Since you added the __linux__ check, do you by any chance know what the Windows equivalent would be?

Thank you!

@xvxx
Copy link
Collaborator

xvxx commented Apr 22, 2019

Should be fixed now yes, sorry! bb46cdf

Do you want to disable static builds on Android too? If so we probably make this change now, and not require using the -ns flag:

diff --git a/src/ldpl.h b/src/ldpl.h
index 71fafd6..fc09c57 100644
--- a/src/ldpl.h
+++ b/src/ldpl.h
@@ -12,7 +12,7 @@
 
 using namespace std;
 
-#if !defined(__APPLE__)
+#if !defined(__APPLE__) && !defined(__ANDROID__)
 #define STATIC_BUILDS 1
 #endif
 

@Lartu
Copy link
Owner Author

Lartu commented Apr 22, 2019

Ah, that could work, yes! Let's do that please! 😄

@Lartu
Copy link
Owner Author

Lartu commented Apr 22, 2019

Hey, you uploaded a macOS binary! Awesome! Thank you very much!

@xvxx
Copy link
Collaborator

xvxx commented Apr 22, 2019

Okay doing that in #58

Hey, you uploaded a macOS binary! Awesome! Thank you very much!

Np! I will do that whenever I see a new release, if I am able to.

@xvxx xvxx closed this as completed Apr 22, 2019
@Lartu
Copy link
Owner Author

Lartu commented Apr 22, 2019

Great! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants