Fixed a bug with the frontpage when there are no news in the database #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This is a quick and dirty fix. I'm now looking for a way to rewrite the code of the frontpage so it does not rely on an ugly counter variable inside the _.each loop to do the rendering. |
|
I understand that the live version will never have this problem, since there are many news already, but it has been a problem for me when trying to setup my local installation of the project. I'm pretty sure other people experienced the same problem. |
|
Makes sense. Thanks! You should have access now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a "No data received" error from '/' and '/news' pages, although the rest of the application worked properly. The bug happens when there are no news items, since the rendering is done inside of the _.each() callback.