Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party platform integration: via importer or separate project integrating finary_uapi? #115

Closed
nmathey opened this issue Oct 17, 2023 · 7 comments

Comments

@nmathey
Copy link
Contributor

nmathey commented Oct 17, 2023

Hi

Thinking about next step of using finary_uapi to sync (add/update/delete) a RealT wallet with Finary.
From your point of view, what would be the best: handling it via creating a specific importer like you did for CSV file import or would be better to start a separate project depending on finary_uapi?

Basically interactions with RealT ecosystems will be with RealT Community API to get latest token data (monthly rent, value, etc.) and the Gnosis blockchain to get current RealT Token list own.

@nmathey nmathey changed the title 3rd party platform integration: via importer or separate project integrating finary_uapi 3rd party platform integration: via importer or separate project integrating finary_uapi? Oct 17, 2023
@lasconic
Copy link
Owner

I would stick with pure "file" importer in finary_uapi (at least in this repo) since they do not require many config options, additional libs etc... In your case, I believe a separate project is better. You could talk to @MadeInPierre, the author of Finalynx to integrate your code in it. He might be more welcoming :)

@nmathey
Copy link
Contributor Author

nmathey commented Oct 18, 2023

Ok it makes sense.
I already integrated RealT into Finalynx since data was missing from Finary: I'll then go with a new project from scratch depending on Finary_uapi like Finalynx.

Thanks

@nmathey nmathey closed this as completed Oct 18, 2023
@MadeInPierre
Copy link
Contributor

Hey! I'd see three options that could work (least to most ambitious):

  1. Many small independent projects that integrate different platforms separately (e.g. realt, ...), each with their own sync logic.
  2. Optionally, if the goal is to manage many integrations, we could separate the integration part of Finalynx in a separate project. This repo (dependent on finary_uapi) would provide centralized portfolio view & sync features for Finary by manually integrating different fetch sources (Finalynx focuses on display/recommendations/simulations).
  3. (Optionally², if the core idea is to create a giant portfolio sync hub, we could define a standard project structure for every platform. Just like extensions made by random people in separate projects, and a quick install would add new sync sources).

Depends on the objective I guess, do you have any? The simplest option would be to create a new repo for RealT, independently from Finalynx ^^ Unless you would see some use from having sync features embedded in Finalynx?

@nmathey nmathey reopened this Oct 18, 2023
@nmathey
Copy link
Contributor Author

nmathey commented Oct 18, 2023

Reopening to make a statement on how we should proceed :)

I was actually up to create a separate project dedicated to RealT sync with finary_uapi as dependence like your did in finalynx.
(I need to understand how to sync/link repo btw maybe with git submodule?)

Now your last option of a portfolio sync hub looks a good idea :)
However I might not be good enough to create the structure. 😅

I can start like I planned for now (since RealT is waited by many Finary/RealT folks and some people from the community are also ready to help) and then see how we can move on bigger project?

Thoughts?

@lasconic
Copy link
Owner

(I need to understand how to sync/link repo btw maybe with git submodule?)

Once your code is in, I will publish a new package and you can depend on it directly in your poetry or requirements.txt file.

@nmathey nmathey closed this as completed Oct 18, 2023
@lasconic
Copy link
Owner

Now that I have a better understanding of real estates in Finary, I wonder if it would make sense to provide an importer from CSV and/or JSON, just like the crypto and securities ones. Your tool @nmathey would then be able to export to this format and then the import would be done by finary_uapi. The advantage : other real estates services (I'm sure we can find other feature requests on the cimmunity) would only have to figure out the export part. Does it make sense ?

@nmathey
Copy link
Contributor Author

nmathey commented Oct 31, 2023

Generic real estate importer could be great yes. It will help people to push their real estate portfolio easily where ever it is coming from.
For RealT integration since it is on the blockchain and can be liquide (thanks to the second market) the sync might happen often and at least every week if we signed the reinvest property. On that note, some RealT community members look enthusiast to work on this too, and might leverage the close relationship they have with official RealT Team to propose something even better (like generating this file directly from the RealT community dashboard :) #fingerscrossed)

What I can propose you is I finalize my code with currencies handling and add some verbose/logging option (I need to learn on this first) then "publish" it to Finary community to get further feedback.
In parallel I will start documenting my findings on your https://github.com/lasconic/openapi-finary (I need to learn also on this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants